---
a/sites/all/modules/contrib/achievements-7.x-1.x-dev/achievements_pointless/achievements_pointless.module
+++
b/sites/all/modules/contrib/achievements-7.x-1.x-dev/achievements_pointless/achievements_pointless.module
@@ -28,14 +28,14 @@ function achievements_pointless_menu_alter(&$items) {
* Process variables for achievement.tpl.php.
*/
function achievements_pointless_preprocess_achievement(&$variables) {
- achievements_pointless_template_hide_variables(&$variables);
+ achievements_pointless_template_hide_variables($variables);
}

/**
* Process variables for achievement-notification.tpl.php.
*/
function
achievements_pointless_preprocess_achievement_notification(&$variables) {
- achievements_pointless_template_hide_variables(&$variables);
+ achievements_pointless_template_hide_variables($variables);
$variables['unlocked_rank']['#markup'] =
$variables['unlocked_date']['#markup'];
// The points box is now entirely empty; replace rank with the unlock
timestamp.
}
@@ -44,7 +44,7 @@ function
achievements_pointless_preprocess_achievement_notification(&$variables)
* Process variables for achievement-latest-unlock.tpl.php.
*/
function
achievements_pointless_preprocess_achievement_latest_unlock(&$variables) {
- achievements_pointless_template_hide_variables(&$variables);
+ achievements_pointless_template_hide_variables($variables);
}

CommentFileSizeAuthor
#8 achievements-Fix_call_by_reference_error-1482852-8.patch601 bytesfabianx

Comments

morbus iff’s picture

morbus iff
they/them
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

circuscowboy’s picture

circuscowboy commented

current dev is still missing one fix

diff --git a/sites/all/modules/achievements/achievements_pointless/achievements_pointless.module b/sites/all/modules/achievements/achievements_pointless/achievements_pointless.module
index 3d27203..029b2d9 100644
--- a/sites/all/modules/achievements/achievements_pointless/achievements_pointless.module
+++ b/sites/all/modules/achievements/achievements_pointless/achievements_pointless.module
@@ -28,7 +28,7 @@ function achievements_pointless_menu_alter(&$items) {
* Process variables for achievement.tpl.php.
*/
function achievements_pointless_preprocess_achievement(&$variables) {
- achievements_pointless_template_hide_variables(&$variables);
+ achievements_pointless_template_hide_variables($variables);
}

/**

morbus iff’s picture

morbus iff
they/them
commented
Status: Closed (fixed) » Reviewed & tested by the community
thedavidmeister’s picture

thedavidmeister commented

This becomes a fatal error in php5.4 btw.

trillex’s picture

trillex commented

Not sure if I should open up a new thread but I recently started getting

Deprecated function: Call-time pass-by-reference has been deprecated in drupal_load() (line 1128 of

It first disappeared after I stopped using the "Pointless" module, which is part of Achievements.

This error, in turn, also gave me issues with Tokens - which were simply not available.

thedavidmeister’s picture

thedavidmeister commented

yeah, open a new thread for each instance of deprecated PHP patterns.

fabianx’s picture

fabianx commented
StatusFileSize
new achievements-Fix_call_by_reference_error-1482852-8.patch601 bytes

Here is the proper patch. Please apply.

deggertsen’s picture

deggertsen commented

This seems like a rather important fix for those of us using PHP 5.4. Could we get this committed?

Thanks for the patch Fabianx.

Anonymous’s picture

Anonymous (not verified) commented

Will someone please commit this?

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

Is this still outstanding from a release version?

Can I help in any way to get it committed?

Thanks, Rachel

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

Committed #8. Thanks!

  • jhedstrom committed 8a1da07 on 7.x-1.x authored by Fabianx 
    Issue #1482852 by Fabianx: PHP 5.3, Call-time pass-by-reference

  • jhedstrom committed 8a1da07 on 8.x-1.x authored by Fabianx 
    Issue #1482852 by Fabianx: PHP 5.3, Call-time pass-by-reference

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.