Currently the Javascript file (tab_builder.js) refers to the last character of id of the accordion that was clicked, so only ever works with accordions 0-9.

This can be fixed by splitting the event id on the - character, rather than always getting the very last char. Patch on the way.

CommentFileSizeAuthor
#2 wysiwyg_tools_plus-maxaccordionfix-1479334-2.patch596 bytesearlofsandwich
#1 wysiwyg_tools_plus-maxaccordionfix-1479334-1.patch1005 bytesearlofsandwich

Comments

earlofsandwich’s picture

earlofsandwich commented
StatusFileSize
new wysiwyg_tools_plus-maxaccordionfix-1479334-1.patch1005 bytes

Here is a patch, hope it's okay. Git on windows :(

earlofsandwich’s picture

earlofsandwich commented
StatusFileSize
new wysiwyg_tools_plus-maxaccordionfix-1479334-2.patch596 bytes

Apologies, I did a diff against head, rather than dev. This patch should be better!

cntlscrut’s picture

cntlscrut commented
Status: Active » Needs review

Good catch.

I'll test it out.

Thanks.

cntlscrut’s picture

cntlscrut commented
Status: Needs review » Fixed

Confirmed tests.

change committed

change included in release 7.x-1.0-alpha2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.