FontFolio

welcome,

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxisraelshmueli1463432git

You can also get a review bonus and we will come back to your application sooner.

regards

I installed the theme on a fresh install of drupal 7.12. The following "notice" is being thrown:

Notice: Undefined index: highlighted in include() (line 93 of /Applications/MAMP/htdocs/drupal7/sites/all/themes/fontfolio/templates/page.tpl.php).

Line 93, page.tpl.php

<?php if ($page['highlighted']): ?><div id="highlighted"><?php print render($page['highlighted']); ?></div><?php endif; ?>

The line is referring to a "region", "highlighted", but you haven't defined that region in your .info file. In other words, if you want to make use of this region, you can add it to your .info:

regions[highlighted]    = Highlighted

Line 103, fontfolio.css

#header_top .search input[type=text] {
  border-left: 1px solid #e4e4e2; /* LTR */
  border: none;

By using "border-left" and "border:none" together, you actually end up with no border. I like the search box treatment in general, but because the input field has no borders, it gets a little confusing when the input field becomes active. The original wordpress theme used the following:

    border-color: -moz-use-text-color -moz-use-text-color -moz-use-text-color #E4E4E2;
    border-style: none none none solid;
    border-width: medium medium medium 1px;

. . . which seems to work better, by rendering a left border.

On the theme configuration page, I tried to enter a facebook link, but I got an error because the other three social url fields were empty. In other words, I can only add a social link, if I add all of them at the same time. Wonder if maybe the form validation can be adjusted to not require the user to enter all four.

Line 60, template.php:

  foreach ($social as $key => $value) {
    if ($value != '') {
      $imgvars['path'] = drupal_get_path('theme', 'fontfolio') . '/styles/images/' . $key . '-icon.png';
      $icon = theme_image($imgvars);
      $vars['social_links'] .= l($icon, $value, $options);
    }
  }

The "theme_image" function expects an array with a field, "attributes". Omitting it is throwing the notice:

Notice: Undefined index: attributes in theme_image() (line 1662 of /Applications/MAMP/htdocs/drupal7/includes/theme.inc).

You could add something like:

$imgvars['attributes'] = array('class' => 'social_links');

. . . after you set $imgvars['path'], to fix this.

Otherwise, looks like a fairly good reproduction of the original wordpress theme.

This looks really good. I installed it on the test site I'm using for my own theme development and it works well.

There are a few text elements that could use some attention. Check links in text, nested lists, definition lists, tables, and blockquotes. Also taxonomy terms rendered after the node content. I wouldn't think that those problems should hold this up from being approved. the Style Guide module can help you to identify things like this when you're working on your theme.

The one thing I'm not sure about is the design credit in the footer. I'm not sure how Drupal's advertising guidelines would apply to something like this, it seems like it wouldn't be allowed (?). But, that's not even your credit, it's from the original Wordpress theme.

I'm going to leave this as "needs review" just because I'm not sure about that credit. Otherwise I would mark it as reivewed & tested.

Well, it looks good to me! I'm new at this, so I hope it's okay if I mark it as Reviewed & Tested by the Community!

You have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

1. I verified that the original Wordpress theme is licensed GPLv2, so no licensing problems in this regard.
2. fontfolio_form_search_form_alter(): this will not work for cached forms, you need to add the javascript with #attached to the form. See http://api.drupal.org/api/drupal/developer!topics!forms_api_reference.ht...
3. "theme_image($imgvars)": do not hardcode this function, use theme('image', ...) instead.
4. "$href = 'http://' . $_SERVER['HTTP_HOST'] . '/';": you should use the global $base_url here, otherwise this will not work if Drupal is installed in a subdirectory of the web root.
5. node-blog.tpl.php: do not build link markup yourself, use l() instead. Also elsewhere.

But that are just minor issues, so ...

Thanks for your contribution, israelshmueli! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

Hi, this is my first post in here. I am implementing the fontfolio theme. I would like to change the grid visualization to a normal listing visualization (such as searching results). Maybe for specific categories. Or maybe in general. Is that possible? I know this way I am not getting the most of this theme's advantage, but I liked the general aspects of the theme but this grid visualization is not pertinent for my blog's type of content.
I would like to know too how can I add the Category field of a post before its title, when only this post is being showed, in order to be like this:
Category > Title

Thanks,

Javier

this is a project application issue wich is *closed* -> you won't get any support here.

please go to the project page: https://drupal.org/project/fontfolio

on the right sidebar you can
- first search for similar issues (https://drupal.org/project/issues/fontfolio?categories=All)
- if you don't find a similar one -> create a new issue in the project's issue queue (https://drupal.org/node/add/project-issue/fontfolio)