A data comparison checking whether a boolean is FALSE.

CommentFileSizeAuthor
#1 rules_boolean.patch768 bytesfago
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Component: Rules Core » Rules Engine
Status: Active » Fixed
FileSize
rules_boolean.patch768 bytes

It looks the problem is that we do a type-safe check then and check 0 vs. FALSE. The attached patch fixes that to never do a type-safe check but to just differentiate between NULL and FALSE values.

Patch attached and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ShaneOnABike’s picture

ShaneOnABike CreditAttribution: ShaneOnABike commented
Component: Rules Engine » Rules Core
Status: Closed (fixed) » Needs review

Sorry did this patch actually get deployed into Rules b/c I am having the same issue here: #1919096: Apply provincial taxes not working

Essentially the Rule to compare a boolean (checkbox) with the checked value fails each time...

ShaneOnABike’s picture

ShaneOnABike CreditAttribution: ShaneOnABike commented

Actually I can see that this was applied sorry for not checking beforehand but it's interesting b/c I see that the rule still fails... I haven't been able to diagnose why but will try and report back.

ShaneOnABike’s picture

ShaneOnABike CreditAttribution: ShaneOnABike commented

Hrmmm never mind I got the latest code and it seems to be working properly now. Thanks!

Status: Needs review » Needs work

The last submitted patch, rules_boolean.patch, failed testing.

TR’s picture

TR CreditAttribution: TR commented
Issue summary: View changes
Status: Needs work » Fixed

This was fixed in #1. It was mistakenly re-opened in #3 and never closed again when the mistake was discovered.

Closing ...

TR’s picture

TR CreditAttribution: TR commented
Status: Fixed » Closed (fixed)