Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Following up from #1321540: Convert DBTNG to namespaces; separate Drupal bits, database.inc was forgotten in core/includes/database
. It should be moved with it's brothers in core/includes
:)
Comment | File | Size | Author |
---|---|---|---|
#9 | database_inc-7.patch | 2.85 KB | amateescu |
#1 | database_inc-second_try.patch | 2.85 KB | amateescu |
database_inc.patch | 185 bytes | amateescu | |
Comments
Comment #1
amateescu CreditAttribution: amateescu commentedAnd now with a working patch.
Comment #2
sunWill most likely come back green, so RTBC. Thanks!
Comment #3
David StraussComment #5
Crell CreditAttribution: Crell commentedIf I'm reading it correctly, #1 is missing the file move.
Comment #6
amateescu CreditAttribution: amateescu commented@Crell, It's there:
Comment #7
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedIt's there, but difficult to spot. There was a problem with test bot earlier, so retesting.
Comment #8
Tor Arne Thune CreditAttribution: Tor Arne Thune commented#1: database_inc-second_try.patch queued for re-testing.
Comment #9
amateescu CreditAttribution: amateescu commentedLet's try to move the rename operation at the bottom.
Comment #11
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedPatch in #1 passed, so setting to RTBC as per #2.
Comment #13
amateescu CreditAttribution: amateescu commentedThere were some testbot issues, described in #1465780-7: Sporadical test failures for a patch that moves a file, which are resolved now, so back to RTBC.
Comment #14
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #15
xjmThe file was deleted but not added to the new directory.
Generally it's a good idea to do this before a commit:
to check for untracked files and see what changes are present or staged.
See also:
http://xjm.drupalgardens.com/blog/gitignore
You can also use
Comment #16
xjmI'd suggest:
Comment #17
devuo CreditAttribution: devuo commentedYeah, that's what I was going to suggest, except for the commit message :P
Comment #18
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedComment #19
xjm@devuo: Got rid of the [HEAD BROKEN]. :D
Comment #20
patrickd CreditAttribution: patrickd commentedHEAD is now working for me,
phew, I was shocked for a moment xP
I think this is fixed now? :>
Comment #21
xjmIndeed, fixed here:
http://drupalcode.org/project/drupal.git/commit/73c878b