use test() to match string for BOOL comparison [#1459164]

Comment	File	Size	Author
#26	ie6.png	10.04 KB	droplet
#10	1459164-javascript_test_instead_match-10.patch	1.69 KB	Kevin Morse

#10	1459164-javascript_test_instead_match-10-D7.patch	1.61 KB	Kevin Morse

#8	1459164-javascript_test_instead_match-8-D7.patch	1.67 KB	Kevin Morse

#7	1459164-javascript_test_instead_match-7.patch	1.69 KB	Kevin Morse

#4	d7-1459164-javascript_test_instead_match-4.patch	1.61 KB	Kevin Morse

#3	d7-1459164-javascript_test_instead_match-3.patch	2.32 KB	Kevin Morse

#2	1459164-javascript_test_instead_match-2.patch	1.65 KB	droplet

	javascript_test_instead_match.patch	2.38 KB	droplet

Comment #1

27 February 2012 at 19:25

Status:

Needs review

» Needs work

The last submitted patch, javascript_test_instead_match.patch, failed testing.

Log in or register to post comments

Comment #2

droplet CreditAttribution: droplet commented 27 February 2012 at 19:33

Status:	Needs work	» Needs review
Issue tags:		+JavaScript clean-up

File	Size
1459164-javascript_test_instead_match-2.patch	1.65 KB

so bad. phpStorm cached the file.

Log in or register to post comments

Comment #3

Kevin Morse CreditAttribution: Kevin Morse commented 13 March 2012 at 05:51

Version:

8.x-dev

» 7.x-dev

File	Size
d7-1459164-javascript_test_instead_match-3.patch	2.32 KB

Here's D7 version.

Shoot I based mine off your original patch. One sec!

Log in or register to post comments

Comment #4

Kevin Morse CreditAttribution: Kevin Morse commented 13 March 2012 at 05:54

File	Size
d7-1459164-javascript_test_instead_match-4.patch	1.61 KB

Here's the version without overlay.

Log in or register to post comments

Comment #5

droplet CreditAttribution: droplet commented 13 March 2012 at 06:00

Version:

7.x-dev

» 8.x-dev

D8 first :)

Log in or register to post comments

Comment #6

Kevin Morse CreditAttribution: Kevin Morse commented 12 April 2012 at 06:13

#2: 1459164-javascript_test_instead_match-2.patch queued for re-testing.

Log in or register to post comments

Comment #7

Kevin Morse CreditAttribution: Kevin Morse commented 12 April 2012 at 06:28

File	Size
1459164-javascript_test_instead_match-7.patch	1.69 KB

This should work against the latest 8.x

Log in or register to post comments

Comment #8

Kevin Morse CreditAttribution: Kevin Morse commented 12 April 2012 at 06:57

File	Size
1459164-javascript_test_instead_match-8-D7.patch	1.67 KB

Here is the D7 version. I tested the password strength functionality in both D7 and D8 and it still works. Not sure what the other part of the patch changes or how I would go about testing it.

Log in or register to post comments

Comment #9

12 April 2012 at 06:59

Status:

Needs review

» Needs work

The last submitted patch, 1459164-javascript_test_instead_match-8-D7.patch, failed testing.

Log in or register to post comments

Comment #10

Kevin Morse CreditAttribution: Kevin Morse commented 12 April 2012 at 07:16

Status:

Needs work

» Needs review

File	Size
1459164-javascript_test_instead_match-10-D7.patch	1.61 KB

1459164-javascript_test_instead_match-10.patch	1.69 KB

Sorry copy and paste error. Here are both D7 and D8 versions. I have triple checked them now and this should be good. Additionally I check the password strength indicators and they are working!

Log in or register to post comments

Comment #11

12 April 2012 at 07:18

Status:

Needs review

» Needs work

The last submitted patch, 1459164-javascript_test_instead_match-10-D7.patch, failed testing.

Log in or register to post comments

Comment #12

Kevin Morse CreditAttribution: Kevin Morse commented 12 April 2012 at 08:03

Status:

Needs work

» Needs review

This just needs review for D8 and then it can be RTBC. I have tested the password strength for D7 and D8.

Log in or register to post comments

Comment #13

droplet CreditAttribution: droplet commented 13 April 2012 at 10:10

Patch #3 looks good. This is similar to my one. needs one more guy to review it :)

Log in or register to post comments

Comment #14

droplet CreditAttribution: droplet commented 13 April 2012 at 10:11

#3: d7-1459164-javascript_test_instead_match-3.patch queued for re-testing.

Log in or register to post comments

Comment #15

droplet CreditAttribution: droplet commented 13 April 2012 at 10:11

Status:

Needs review

» Needs work

Needs someone reroll #3 against D8.

Log in or register to post comments

Comment #16

nod_

French

Lille

CreditAttribution: nod_ commented 13 April 2012 at 14:41

Status:

Needs work

» Reviewed & tested by the community

Green patch in #10 it good for D8.

Log in or register to post comments

Comment #17

Kevin Morse CreditAttribution: Kevin Morse commented 13 April 2012 at 21:40

#10 has the D7 and D8 rerolls.

Log in or register to post comments

Comment #18

catch

he/him

English

CreditAttribution: catch commented 17 April 2012 at 03:38

Status:	Reviewed & tested by the community	» Needs review
Issue tags:		+Needs backport to D7

Committed/pushed to 8.x, moving to 7.x for backport. Already a patch here so CNR.

Log in or register to post comments

Comment #19

Kevin Morse CreditAttribution: Kevin Morse commented 17 April 2012 at 04:18

Version:

8.x-dev

» 7.x-dev

I already tested the password strength of that patch in D7 and it works!

Just tested the date and time preview at Configuration » Regional and language » Date and time » Formats and it appears to be working as well! I would say this is RTBC but the issue needs to change to 7.x and the patch should probably be tested again...

Log in or register to post comments

Comment #20

Kevin Morse CreditAttribution: Kevin Morse commented 17 April 2012 at 05:23

#10: 1459164-javascript_test_instead_match-10-D7.patch queued for re-testing.

It passed! I'd say this one is RTBC but probably someone else should look over it.

Log in or register to post comments

Comment #21

Kevin Morse CreditAttribution: Kevin Morse commented 22 April 2012 at 19:38

Status:

Needs review

» Reviewed & tested by the community

Just tested this again. In as many possible ways as I could and I couldn't find any problems. Seeing as the 8.x version was passed, this is an identical patch, and no one else is looking at it. I'm going to say that #10 (the D7 version) is RTBC.

Thanks!

Log in or register to post comments

Comment #22

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 23 April 2012 at 02:14

Status:

Reviewed & tested by the community

» Needs review

Can you please clarify what browsers you're testing in? For D7 we need things tested in IE6 & 7.

Log in or register to post comments

Comment #23

Kevin Morse CreditAttribution: Kevin Morse commented 23 April 2012 at 02:22

Eeek... IE6

I tested in FF11, Chrome 18, IE9

Log in or register to post comments

Comment #24

nod_

French

Lille

CreditAttribution: nod_ commented 28 April 2012 at 14:36

Status:

Needs review

» Reviewed & tested by the community

Ok I don't actually have IE6 on me but that is a really straight forward patch. You don't have weird behaviors with simple regex like that.

Feel free to burn me on the public place if this patch fails in IE6 :)

Log in or register to post comments

Comment #25

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 29 April 2012 at 06:27

Status:

Reviewed & tested by the community

» Needs review

Well, hopefully someone can and they can test #1420798: autocomplete.js clean up while we're at it. D7 is a stable release; I can't roll out changes without testing. :\ Especially with a release coming up on Wednesday.