A follow-on to: http://drupal.org/node/137767

Right now, menu module doesn't work at all, the code to move menu links within the tree doesn't exit, and we need to do at least a few performance optimizations.

CommentFileSizeAuthor
#11 menu_module_7.patch33.2 KBchx
#10 menu_module_6.patch33.2 KBchx
#9 menu_module_5.patch101.12 KBchx
#8 menu_module_4.patch33.2 KBchx
#7 menu_module_0.patch102 KBchx
#6 menu_module.patch30.89 KBchx
#4 menu_module_only_3.patch24.94 KBpwolanin
#3 menu_module_3.patch26.84 KBpwolanin
#2 menu_module_2.patch26.07 KBpwolanin
#1 menu_module_1.patch27.78 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs work
StatusFileSize
new menu_module_1.patch27.78 KB

initial work on conversion- nothing in menu module works yet.

pwolanin’s picture

pwolanin commented
StatusFileSize
new menu_module_2.patch26.07 KB

slight rethinking.

pwolanin’s picture

pwolanin commented
StatusFileSize
new menu_module_3.patch26.84 KB

a start on the code for blocks

pwolanin’s picture

pwolanin commented
Assigned: pwolanin » Unassigned
StatusFileSize
new menu_module_only_3.patch24.94 KB

per my discussion over e-mail with Karoly- I will handle primarily the code for menu.inc, while he'll work on menu.module, etc.

Splitting of the menu.inc part into a separate issue: http://drupal.org/node/145058

Attached is the part of the previous patch that is specific to menu.module and menu.install

pwolanin’s picture

pwolanin commented

Just trying to think about how the install/update process will run.

I think it makes sense to have the update code as part of system.install? I guess it could be in menu.install instead?

I think 'menu' should be added here in default.profile:

function default_profile_modules() {
  return array('color', 'comment', 'help', 'taxonomy', 'dblog');
}
chx’s picture

chx commented
StatusFileSize
new menu_module.patch30.89 KB

We have a new , much more logical arrangement for admin/build/menu , menu add/edit works, menu item add/edit works, enable/disable works. There is an untested attempt at blocks. Will be finished today, I hope.

chx’s picture

chx commented
StatusFileSize
new menu_module_0.patch102 KB

Between two parallel patches I lost some code. This one indeed does: add/edit menu, menu item, enable/disable menu item.

chx’s picture

chx commented
StatusFileSize
new menu_module_4.patch33.2 KB

module only patch

chx’s picture

chx commented
StatusFileSize
new menu_module_5.patch101.12 KB

typo fix

chx’s picture

chx commented
StatusFileSize
new menu_module_6.patch33.2 KB

module only...

chx’s picture

chx commented
StatusFileSize
new menu_module_7.patch33.2 KB

So very hard to work without http://drupal.org/node/145058 committed.

joshk’s picture

joshk commented

This patch is actuallly required for http://drupal.org/node/145058 to work, as I just discovered.

Also, you missed a reference to menu_get_root on line 648, which is the settings form.

chx’s picture

chx commented
Status: Needs work » Closed (duplicate)

I opened another issue... i forgot about this one.