Closed (fixed)
Project:
Lightbox2
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 May 2007 at 14:21 UTC
Updated:
9 Jul 2007 at 09:47 UTC
The img_assist module has a popup window for selecting and inserting image nodes into other content. This select window displays a number of image thumbnails with links to the image node that is to be selected and inserted. Because of this, Lightbox2 thinks that it needs to rewrite the link, which heavily interferes with img_assist's image selection process.
One possible solution would be to disable the Lightbox2 scripts on the img_assist pages. The selection page has a body id of "img_assist_thumbs" and a body class of "img_assist", if that helps at all.
Comments
Comment #1
stella commentedPatches have been added to CVS to prevent it from interfering with the images in the img_assist pop-up window. You can either download the latest version from CVS or switch off image node support on the settings page. It will be included in the next release.
Cheers,
Stella
Comment #2
(not verified) commentedComment #3
ashtonium commentedFirst off, thanks for your quick response to the original posting. I've finally gotten time to test the 5.x-1.x-dev version, and it isn't fixing the issue.
I've looked at your changes, and they seem like they should fix the problem, but the issue still exists. I think this may be because Element.hasClassName wants an id string as the first value, at least according to the example page: http://wiki.script.aculo.us/scriptaculous/show/Element.hasClassName
I tested out
if (!Element.hasClassName('img_assist_thumbs', "img_assist")) {which does work, but there may be a better way to do it, as I'm no javascript guru.
Comment #4
stella commentedThanks for that. I've corrected this for both the drupal 5.x and 4.7.x versions and have checked them into CVS. They will be included in the next release.
Cheers,
Stella
Comment #5
ashtonium commentedLooks good, seems to be working very well now.
Just as a side note, I don't think this line is needed anymore either:
var body = document.getElementsByTagName("body");since we're not passing the body element to Element.hasClassName anymore.
Thanks again for you're quick responses,
-Ashtonium
Comment #6
stella commenteddone, thanks.
Comment #7
stella commentedMarked #151292 as a duplicate of this issue.
Comment #8
(not verified) commented