Hi all,

My entire site's wrapped in a nice layer of good old SSL. I've run into a snag while using Twitter_Pull in that the images for Twitter Profiles are being yanked from a non-SSL source. Since Internet Explorer likes to be butthurt about these things, it's a problem.

Looking at the Profile image's origin, I get this URL: http://a1.twimg.com/profile_images/368808850/blahblahblahnotreal.jpg

I looked through the source code of the module and unless I'm missing it, I have no idea how the module is pulling the image from that site, or if it's even possible to get an SSL equivalent.

The module is great otherwise, but unfortunately I am at the mercy of Internet Crapsplorer. IF there's no way around it I'll just have to look for another module that will work with this.

CommentFileSizeAuthor
#3 twitter_pull-https_profile_images-1443194-3.patch2.73 KBjojonaloha
#1 twitter_pull-https_profile_images-1443194-1.patch1.91 KBjojonaloha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jojonaloha’s picture

jojonaloha CreditAttribution: jojonaloha commented
Version: 6.x-1.2 » 7.x-1.x-dev
Category: support » bug
Status: Active » Needs review
FileSize
twitter_pull-https_profile_images-1443194-1.patch1.91 KB

I've attached a patch which pulls the profile_image_url_https as well and then uses that one when on https. It has to store both because the results are cached and may not always be displayed under https or not.

mrfelton’s picture

mrfelton CreditAttribution: mrfelton commented
Status: Needs review » Needs work

Works for me with rc1. Doesn't apply cleanly to rc2 though. I think the patch needs updating a little.

jojonaloha’s picture

jojonaloha CreditAttribution: jojonaloha at Metal Toad commented
Status: Needs work » Needs review
FileSize
twitter_pull-https_profile_images-1443194-3.patch2.73 KB

I've re-rolled the patch against the latest dev.

icarnaghan’s picture

icarnaghan CreditAttribution: icarnaghan commented
Version: 7.x-1.x-dev » 7.x-1.0-rc3

I tried applying the patch to RC 3 for Drupal 7, however I am seeing only the main twitter account profile images being displayed, any retweets, etc. are not appearing. Is there anything else that can be applied to this for all images to work using https?

jec006’s picture

jec006 CreditAttribution: jec006 commented
Status: Needs review » Fixed

Patch committed, thank you.

I also added support for retweeted user icons in ssl.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

icarnaghan’s picture

icarnaghan CreditAttribution: icarnaghan commented

Thank you, it works perfectly now! :)

joels01’s picture

joels01 CreditAttribution: joels01 commented

If this was fixed in previous versions, any reason why it's still happening in 7.x-2.0-alpha3?