Because the title for a block can be which displays as nothing, you can have a block with no title or content that doesn't get the filler text which can be frustrating to edit. The patch below just alters the if statement to include if($block['title'] == '') as well as empty.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wbobeirne’s picture

wbobeirne’s picture

Status: Active » Needs review
tirdadc’s picture

Status: Needs review » Fixed

Tested it out and committed it. Thanks!

alphageekboy’s picture

Status: Fixed » Needs review
FileSize
1 KB

The original patch worked great for displaying the block when logged in with appropriate rights. However, this prevented the box from completely hiding if it was empty when you didn't have edit rights for the box. Thus, the box would still render with empty content. Ideally, we want to the box to not render when you do not have edit rights.

The patch attached adds a return if the box is empty and you do not have box edit rights. This prevents the box from being rendered if "Hide if empty" is checked and you do not have box edit rights.

tirdadc’s picture

Status: Needs review » Fixed

Reformatted some stuff including comments and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alphageekboy’s picture

Version: 7.x-1.x-dev » 7.x-1.0-beta7
FileSize
1.04 KB

Attaching a patch against the beta7 version of boxes for the above. The original patch was patched against the dev version.