thanks for module it is very helpful.

Found a little bug if not in /checkout/XX view the order but for example in link admin/commerce/orders/XX/edit. In case if $form array does not hold ['#parents'][0] write error message:
Notice: Undefined offset: 0 commerce_extra_address_populate_field_attach_form()

Here a patch to solve this problem please review it.

Regards,
Joe

Comments

dj1999’s picture

Title: Hello, » Undefined offset: 0 commerce_extra_address_populate_field_attach_form()
imiksu’s picture

Status: Needs review » Fixed

Nice one, thanks!

I replaced the tabs to normal whitespaces like coding standards says ;)

Committed to 1.x-dev branch.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

star-szr’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new672 bytes

Looks like some tabs still got introduced here, patch attached :)

star-szr’s picture

Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
imiksu’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

quantos’s picture

Version: 7.x-1.x-dev » 7.x-1.0-alpha1
Status: Closed (fixed) » Active

Hi guys. I'm getting the very same error popping up my dev site, although I'm not on my local site and having looked around can't see anything other than this thread about it - so I've re-opened. I hope that's OK.

I'm still working my way through the issue but what I'm getting, inserted just above my Delivery Options fieldset, is:

Notice: Undefined offset: 0 in commerce_extra_address_populate_field_attach_form() (line 65 of /home/peachydev/peachydev.dreamhosters.com/sites/all/modules/commerce_extra/modules/address_populate/commerce_extra_address_populate.module).
Notice: Undefined offset: 0 in commerce_extra_address_populate_field_attach_form() (line 65 of /home/peachydev/peachydev.dreamhosters.com/sites/all/modules/commerce_extra/modules/address_populate/commerce_extra_address_populate.module).

The main question to you is whether this is fixed in 7.x-1.0-alpha1 release or just in the x-dev version? If the latter, is the x-dev considered stable enough for use? The site set-up is Omega/delta/context + commerce/extra.

Thanks in advance.

Q.

star-szr’s picture

Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
Status: Active » Closed (fixed)

@quantos - this is fixed in 7.x-1.x-dev. I've used the dev version on two sites with no issues.

quantos’s picture

Many thanks Cottser. Much appreciated feedback.

EDIT: Applied and tested now too. Works a treat. Thanks guys.

anybody’s picture

This issue still exists ("Undefined offset: 0 in commerce_extra_address_populate_field_attach_form()") in the alpha version. What about a new (alpha2) release in the future?
The .dev works great, thanks!