I have jQuery UI 1.8.11 and in that case you fallback on a load that doesn't work in the current development version.

if (jquery_ui_get_version() > 1.6) {
  // jquery_ui_add(array('jquery.ui.sortable')); -- not enough!
  jquery_ui_add(array('jquery-ui', 'jquery.ui.widget', 'jquery.ui.sortable'));
}

The patch includes a fix to the indentation and additional { and } that are required (in Drupal) even when an if() is followed by a single line of code. Plus, it's good practice.

Thank you.
Alexis

CommentFileSizeAuthor
ckeditor-6.x-jquery_ui.patch1.94 KBAlexisWilke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AlexisWilke’s picture

AlexisWilke CreditAttribution: AlexisWilke commented

One other note...

The files are named jquery.ui.something. In the original, the "jquery." part was missing.

Thank you.
Alexis

mkesicki’s picture

mkesicki CreditAttribution: mkesicki commented

@AlexisWilke thank you for patch.

dczepierga’s picture

dczepierga CreditAttribution: dczepierga commented
Status: Needs review » Closed (won't fix)

First of all, jquery_ui module support only jQuery UI up to 1.7.3 version... from version 1.8 jQuery UI has prefix jquery. before each file.
The second thing is does jquery_ui_get_version function work only up to 1.7.3 version of JQuery UI, so with newer version it wouldn't be work and will be return 0.
Also before jQuery UI 1.8 u doesn't have something like jquery.ui.widget so it doesn't help.

So i think this issue can be closed, because it doesn't make sense.

Greetings

AlexisWilke’s picture

AlexisWilke CreditAttribution: AlexisWilke commented

I have jquery 1.5.2 and jquery.ui 1.8.11. So that explains the problem. I suppose the patch would need to test the version of jquery.ui but how to get that version if you cannot load the library first?! 8-)

Anyway, thank you for looking into it and explaining the situation.
Alexis

wwalc’s picture

wwalc CreditAttribution: wwalc commented
Status: Closed (won't fix) » Active

One user reported the same problem, so it looks like there is something wrong here.
Well, at least we should detect incompatible/wrong configuration and load appropriate files when needed.