Closed (fixed)
Project:
Chatroom
Version:
4.7.x-1.12
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
11 May 2007 at 19:51 UTC
Updated:
15 Jul 2007 at 23:16 UTC
Jump to comment: Most recent file
Reported by ajwwong:
When someone uses double quotes!!! it BREAKS the chat....
try it out...
but then... when the window gets flushed... another 10 lines of someone test entering into the text box... eventually the double "quotes" get flushed out of the window... and the chatroom revives... Ding ding ding...
Now... if I only knew how to fix it :-)
It seems related to this JS error in www.ithou.org/Big_House
missing } after property list
[Break on this error] [{msgs:[{id:1282,text:"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",user:"xxxxxx",ti...
BTW, that error above comes from chatroom.js line 52
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | chatroom_12.patch | 1.06 KB | Steve Dondley |
Comments
Comment #1
ajwwong commentedsubscribing
Comment #2
ajwwong commentedSee also here for another sighting of this bug: http://drupal.org/node/144598
Comment #3
ajwwong commentedIf anyone wants to see this bug in action you should be able to go here to these two test chat rooms to experiment:
Chatroom that is already frozen:
http://www.ithou.org/chatrooms/chat/4 [if it is not frozen you can freeze it by typing in double quotes as data somewhere in the text]
However, on the EXACT same site this other chat room works [at least until someone types in a double quote]:
http://www.ithou.org/chatrooms/chat/3
If by chance someone has already been fiddling around with these and they are both frozen, you can reset the rooms by typing in a large number of new lines of text into the text entry space [approximately 15 lines] and then refreshing the screen. The chat room should "un-freeze" and go live again.
Thanks for looking at this.
Blessings,
Albert
Comment #4
Steve Dondley commentedThanks for figuring this out and taking the time to post. I would have never found the problem.
Comment #5
Steve Dondley commentedOK, here is a patch. It escapes characters into the html entities upon submission and unescapes them when they get added to the chat message area.
Comment #6
ajwwong commentedpatch appears to work just fine! fixes the problem!
Thanks so much for finding a solution!!!!
Blessings
Albert
Comment #7
darren ohThe problem was caused by an error in the code. Fixed in CVS commit 71989.
Comment #8
(not verified) commented