It's good practice, and can avoid errors from showing, if you check to ensure arrays have data before processing them.

CommentFileSizeAuthor
#1 subscriptions-n1430484-d6.patch4.76 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new subscriptions-n1430484-d6.patch4.76 KB

Patch for D6 enclosed.

salvis’s picture

salvis
he/his
commented

I agree in principle, but please explain concretely what issues you found and how you're solving them.

D7 first...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I'll work on a D7 patch.

These patches come from my efforts to cleanup a site that was built in 2009 with the 6.x-1.x-dev version of this module from April 19th 2009 and was then heavily hacked by someone who didn't know Drupal. Some of the hacks were for bugs but most were to tailor the module to their specific use cases. This specific patch may be for a bug that no longer exists, but I don't know for certain right yet.

salvis’s picture

salvis
he/his
commented
Status: Needs review » Needs work

That's not a good approach. If we cannot identify the problem that we're trying to fix and cannot confirm that we actually did fix it, we're more likely to break something.

Subscriptions is used by a couple thousand of sites and we have a responsibility there.

salvis’s picture

salvis
he/his
commented
Status: Needs work » Closed (won't fix)

This is not committable as-is.