sejmometr api

Hello! How I can review your module? Please add link to repository of your project.

Please also add the sandbox link to the issue summary.

The response time for a review is now approaching 4 weeks. Get a review bonus and we will come back to your application sooner.

Hi
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./sejmometr_api.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function node_silent_delete($nid) {
  function sejmometr_remove_content($content_type) {
  

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

See report attached.
You should also specify if the module is for drupal 7 or 6.

Looking on the project page, I think you should add more details about your module, maybe a screenshot if possible. Here is an example: http://drupal.org/project/pathauto.

Looking into the code, I saw that you don't have a @doc block for your functions. You should add one for each function, here is the proper format http://drupal.org/node/1354.

.install file
Here you should avoid using the t() function. Use this one instead http://api.drupal.org/api/drupal/includes!install.inc/function/st/7. Here is the reason: Used during the install process, when database, theme, and localization system is possibly not yet available.
Line 309:
$filename = drupal_get_path('module', 'sejmometr_api') . "/includes/cck/parliament_club.inc";
A better way would be to use this function module_load_include().

.module file
Line 468: Instead of file_get_contents() you should use drupal_http_request(). It's a more proper way to get the url.

Hi,
What I meant was, from this page http://drupal.org/node/1011698 point 4-5. Offcourse I saw the branch name and .info file, but it's just easyer for someone who want's to checkout your module to know if he/she should do it in a drupal 6 or 7 installation.
PS: changed the status to needs review to get a review ;)

Project page link and repository info

Review of the 6.x-1.x branch:

• Remove the translations folder, translations are done on http://localize.drupal.org
• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/./test_candidate/sejmometr_api.install:
 +413: [normal] The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.
 +414: [normal] The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.

Status Messages:
 Coder found 27 projects, 27 files, 2 normal warnings, 0 warnings were flagged to be ignored

FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/sejmometr_api.module
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
   16 | ERROR | File doc comments must be followed by a blank line.
   92 | ERROR | More than 2 empty lines are not allowed
  884 | ERROR | Additional blank line found at the end of doc comment
 1218 | ERROR | Inline comments must end in  full-stops, exclamation marks, or
      |       | question marks
 1780 | ERROR | Inline comments must end in  full-stops, exclamation marks, or
      |       | question marks
 2243 | ERROR | There must be no blank line following an inline comment
 2687 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

Here is my manual review:

Personnally I don't get the point to create a sejmometr_api_conf table when you have the variables table.
All your submodules have no code, all the .inc files in your submodules are missing <?php tag at the beginning.

Here's what PHPStorm told me when opening you project:
Undefined constant WATCHDOG_WARN in file sejmometr_api.module
Undefined variable 'user' in file sejmometr_api.module:1123
Undefined variable 'session_day' in file sejmometr_api.module:1493
Variable 'mp' might have not been defined in file sejmometr_api.module:2264
Undefined variable 'si' in file sejmometr_api.module:2664
Undefined variable 's_info' in file sejmometr_api.module:2667
Unused local variable $doc_url in file sejmometr_api.module
Unused local variable $user in file sejmometr_api.module
Unused local variable $user in file sejmometr_api.module
Unused local variable $url in file sejmometr_api.module
Unused local variable $s in file sejmometr_api.module

I do not really get the explanation above - why is there import files for cck, and why are they missing <?php tags? And why have the submodles no code in them? These seem to be so specific code that it can not be a generic module, are am I missing something here?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Update - info about new nodes