Updated to 5.x

I gave this a try because I'd really like to be able to embed nodes (e.g. image nodes whose body text is a key for the image) within a main story. It *almost* works, but there are a couple of nasty faults (can't tell if they are related). I've not used drupal versions prior to v5 so can't compare how well this module works under v4 releases.

The problems I get are:
The following error message after submitting any change once the module is enabled -

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1 WHERE cid = 'filter'' at line 1 query: DELETE FROM 1 WHERE cid = 'filter' in /var/www/html/karoscene/includes/database.mysql.inc on line 172.

An embedded image node with a plain HTML body with a table (it's a parts diagram and matching key) is displayed with a thumbnail, but the div block it appears in isn't closed properly, leading to all the remaining page text appearing withing the block, with the table data at the end - very mashed :-(

The trouble probably all stems from the SQL error, but I'm not knowledgable enough about drupal internals to track it down.

Yes, I would have thought so too. I've not got a particularly exotic set of additional modules, but started again from scratch to reproduce the problem. Here's the setup:

No, the site isn't online - it's as I described, a vanilla drupal install with just attached_node added.

Having gone grepping, it seems that the source of the bad SQL is the clear_cache_all() function in cache.inc:

function cache_clear_all($cid = NULL, $table = NULL, $wildcard = FALSE)

Almost the last line of the file is where the "DELETE FROM .. WHERE cid = .." query appears. This function is called by attached_node.module here:

function attached_node_nodeapi(&$node, $op) {
  if($op == "update") {
    // since this is a node-specific filter, clear the cache when nodes are updated
    cache_clear_all('filter', true);
  }
}

I'm not sure what this is trying to do, but the parameters being passed don't seem to line up with those expected by the function. Commenting it out stops the error but (obviously) no longer does what was intended either.

Any help?

Yup, that's much better!

My other issue with duff HTML appears to be caused by the point at which the teaser block is cut - my embedded image node has a plain HTML table in the body text, but it's getting cut off after a few rows. If I put

<!--break-->

at the end of the body text then the page rendering works fine. So, things are starting to look good.

My remaining issue is that filter text like [node:20,res="original"] doesn't seem to give me a full size image, just the thumbnail. Am I doing this right? Seems to be as described in the help, although when I look at the attached_node help page where it lists the parameters which can be overridden for each node type, none are listed.

cheers

Ah, OK I hadn't twigged that you have to configure the filter with the params to be allowed. Having added title,res,width I can use [node:20,res="original",title="foobar"] and get just what I expect. Can't seem to get any difference when trying to specify a width though.

I didn't have to go fiddling with the database to get this to work. However, I have had problems elsewhere in filter config with settings not being applied. E.g. I added some extra HTML tags to the HTML filter and found that they didn't 'take' when saving settings from the Configure form, but *did* if I then switched back to the View form and saved there too.

Getting width to work would make this module perfect - extremely useful for layouts of more elaborate articles. Can achieve the same effect by editing the CSS, but of course that's global.

Nice work.

I've rerolled the patch with the cache fix and added the module info file needed by Drupal 5.x. Seems to work for me.

I can confirm the 4.7 attached_node, patched as per this issue, runs fine on 5.2.

This should be pushed out.

+1 for rolling this out as a package - I upgraded from 4.7.7 to 5.2 and patcher per this node info, and it works fine.

FYI - I WOULD love to see attached_node ported to 6.x as well - I'll be rolling to 6.x ASAP - and I dearly rely on the attached_node - I think attached_node should be a part of core ... It's one of those "duh" modules, the ability to include chunks of text into other nodes. Take a "news" page for example, each news article gets a footer with "About ... " information on the company ... just create a node and include it - BOOM! Done! Thanks for listening. Thanks for maintaining the code!

There is a new module available for 5.x which more or less does the same thing as Attached Node:
http://drupal.org/project/InsertNode

It might be a good idea to do any new development there, seeing as how Attached Node looks like it's near death... ;)