E_ALL: Undefined variable: bytes in includes/unicode.inc on line 469. [#142337]

At several points I'm getting warnings for notice: Undefined variable: bytes in includes/unicode.inc on line 469.

The only code flow I can see that would cause it is if $multibyte != UNICODE_MULTIBYTE and $start == 0. I'm not certain that $bytes = 0 is correct but it's no worse than what's happening now.

Comment	File	Size	Author
#4	unicode.inc_142337_0.patch	693 bytes	drewish
#2	unicode.inc_142337.patch	526 bytes	drewish
	unicode.inc_.patch	427 bytes	drewish

Comments

Comment #1

marcp commented 11 May 2007 at 19:04

I can confirm that the patch fixes the problem. I saw this happen a few times -- most recently on admin/build/modules after submission of the form.

Comment #2

drewish commented 11 May 2007 at 23:15

Status	File	Size
new	unicode.inc_142337.patch	526 bytes

after a little debuggering i figured out that this is happening as part of the menu rebuild. this is being called by drupal_ucfirst() which calls drupal_substr() twice once for the first character and again for the rest. so you get drupal_substr('Page', 0, 1) and drupal_substr('Page', 1). the attached patch is a little simpler.