Use a conditional comment to only add the hacks for IE to keep the regular css clean. Note I just wrote the patch up and didn't actually test it in IE yet, so please test this. Thanks.

CommentFileSizeAuthor
nice_menus_ie_css.patch2.55 KBadd1sun

Comments

herb’s picture

herb commented

I'd like to help test this, but I'm having trouble applying the patches, and am beginning to get confused as to whether they are cumulative or self contained against the "standard" version. Anyway, would it be possible for you to attach the complete nice_menus.css stylesheet(s) to a post so that I could test it against IE6 and IE7.

herb’s picture

herb commented

Please ignore my previous post. I'm new to this, and didn't realize there were 3 separate patches to be applied. All patches worked so I'll try to test it now.

herb’s picture

herb commented

Tested the patches and still didn't get any 2rd level menus using IE6. FWIW, I tried adding the separate conditional ie.css to nice_menus.css in case it wasn't being recognized by IE6, but it seemed to have no impact on any of my browsers. I'm using a modified bluemarine theme.

JamesSharpe’s picture

JamesSharpe commented

The patch breaks the drupal method of handling css files - it will break with css aggregation as the html head is being set explicitly independantly of the css functions. I think that adding platform/browser specific css files is a capability that perhaps should be considered as being added to core as there is currently no correct way to do this without breaking some themes.

add1sun’s picture

add1sun commented
Status: Active » Needs review

@herb, this patch has nothing to do with the menus not flying out properly, this is simply an organization/validation patch. The menu flyout for IE6 patch is in that issue: http://drupal.org/node/141135

Please test that patch and report back to that issue. Thanks!

herb’s picture

herb commented

Sorry - I thought I did already? Comment #4 where it didn't work for me but I'll try again.

add1sun’s picture

add1sun commented
Version: 5.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Postponed

Postponing this til Drupal 6 where aggregation works better with other css files.

add1sun’s picture

add1sun commented
Status: Postponed » Closed (won't fix)

Honestly the IE-specific CSS isn't that much and we already have 2 CSS files for people to keep track of, so at this point I'm thinking we won't do this anyway, unless someone has a really compelling reason.