+++ b/core/modules/shortcut/shortcut.admin.js
@@ -79,7 +79,7 @@ Drupal.behaviors.shortcutDrag = {
-      };
+      }

This shouldn't be a local function in the first place. Let's open a follow-up issue for that.

ref: http://drupal.org/node/1399496#comment-5528104

CommentFileSizeAuthor
#8 shortcut.patch1.64 KBdroplet
#4 core-js-tableDrag-local-1420056-4.patch1.66 KBnod_
local_function.patch1.29 KBdroplet

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +JavaScript clean-up
nod_’s picture

nod_
Primary language French
Location Lille
commented

tested and works, I'd like to know the why though.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Local functions are invisible and cannot be overridden in any way.

Didn't look into details, so it might turn out that the entire tableDrag object is local, but fixing that would be a separate/larger issue.

Thanks! If this is confirmed to work, RTBC for me.

nod_’s picture

nod_
Primary language French
Location Lille
commented
StatusFileSize
new core-js-tableDrag-local-1420056-4.patch1.66 KB

rerolled, it was missing a semicolon after the function declaration, funny hey :)

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

good catches

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

droplet’s picture

droplet commented
Version: 8.x-dev » 7.x-dev
Status: Closed (fixed) » Needs review
Issue tags: +Needs backport to D7
StatusFileSize
new shortcut.patch1.64 KB
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Backport looks fine as well.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.