A couple of var are not initialized properly and leak into the global space. The patch fixes that.

CommentFileSizeAuthor
#6 core-tabledrag-fix-leak-1414824-6.patch1.64 KBnod_
#6 core-tabledrag-fix-leak-1414824-6-D8.patch1.1 KBnod_
core-tabledrag-fix-leak.patch730 bytesnod_

Comments

Status: Needs review » Needs work
Issue tags: -JavaScript

The last submitted patch, core-tabledrag-fix-leak.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Needs review
Issue tags: +JavaScript

core-tabledrag-fix-leak.patch queued for re-testing.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community
nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +JavaScript clean-up
dries’s picture

dries commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 8.x. Thanks.

We should consider back-porting this to 7.x so I'm moving it to 7.x.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new core-tabledrag-fix-leak-1414824-6-D8.patch1.1 KB
new core-tabledrag-fix-leak-1414824-6.patch1.64 KB

found one more leaking var in the same file, D7 patch for the 3 and the D8 is updated to fix the one i missed before.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Reviewed & tested by the community

It's ok, commit first the D8 part.

dries’s picture

dries commented
Version: 8.x-dev » 7.x-dev

Committed to 8.x. Moving to 7.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks good, and can't think of a way this could break 7.x sites, given it's just better scoping.

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

typo