Attached will be a patch that fixes some errors when you use the identifier.

CommentFileSizeAuthor
#2 menu_parent_trail_brings_db_error-1414674-2-screenshot_1.png171.65 KBfengtan
#2 menu_parent_trail_brings_db_error-1414674-2-screenshot_2.png100.36 KBfengtan
#1 1414674-d7-1.patch1.47 KBredndahead

Comments

redndahead’s picture

redndahead commented
Status: Active » Needs review
StatusFileSize
new 1414674-d7-1.patch1.47 KB

Here is the patch.

fengtan’s picture

fengtan
Location Montreal, Canada
commented
StatusFileSize
new menu_parent_trail_brings_db_error-1414674-2-screenshot_2.png100.36 KB
new menu_parent_trail_brings_db_error-1414674-2-screenshot_1.png171.65 KB

Reviewed & tested this patch, which looks ok and fixed the problem. Thank you.

Here is a detailed plan to reproduce the issue, if anyone is interested:

  1. Enable module custom_breadcrumbs_identifiers
  2. Go to admin/structure/custom_breadcrumbs/node/add
  3. Fill up the form and make sure that the 'path' textarea contains the <menu-parent-trail> special identifier. See example in screenshot 1
  4. Click on 'Save'
  5. Go to node/add/page and create a page node
  6. View the node: there is a SQL error. See screenshot 2.
luisortizramos’s picture

luisortizramos commented
Status: Needs review » Reviewed & tested by the community

I've tested the path in #1 against the latest dev version and it works like a charm.

+1 to commit it

Thanks redndahead

kyberman’s picture

kyberman
Location Czech Rep. 🇨🇿
commented
Issue summary: View changes

Tested patch #1 against 2.0-beta1 and dev - it works well and should be committed. Thank you redndahead.

renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib

Thank you very much people.

I tested with patch and really works good.

  • RenatoG committed 0a3fafa on 7.x-2.x authored by redndahead 
    Issue #1414674 by redndahead, fengtan, luisortizramos, kyberman, RenatoG...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Thank you very much people for contributions.

Good Work.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.