Visible in attached. Assuming it's just a CSS issue. The groups block is improperly floated next to the other history and overlaps in fun and bewildering ways. Observed in chrome.


#9 G_D_O_ProfileCSS.png86.23 KBbanghouse
#4 og.patch761 bytesdrumm
PASSED: [[SimpleTest]]: [MySQL] 269 pass(es). View
gdo_history_bluecheese.png12.72 KBxjm
Members fund testing for the Drupal project. Drupal Association Learn more


xjm’s picture

Sorry, this is on the user profile page.

xjm’s picture

This also happens in Safari, but not FF, so looks like a webkit issue.

xjm’s picture

Issue tags: +gdolove

Tagging for love!

drumm’s picture

Title: Display bug on using bluecheese » User profile items should be user_profile_item
Project: Bluecheese » Organic groups
Version: » 6.x-2.x-dev
Component: Code » og.module
Assigned: Unassigned » drumm
Status: Active » Needs review
761 bytes
PASSED: [[SimpleTest]]: [MySQL] 269 pass(es). View

'item' type is for forms, which isn't right for user profile pages. Bluecheese works well with this change. It is only shown for yourself and group admins, so not critical.

Grayside’s picture

I took a gander at user.module just to double check and it looks good, but I'm not clear on how to reproduce this issue and what we are worried about seeing breakage-wise.

drumm’s picture

In core, and bluecheese, user-profile-category.tpl.php starts a <dl> and user-profile-item.tpl.php makes a <dt> and <dd> for each. We have ours positioned with floating, so dropping an unfloated form item in breaks the layout. It is probably invalid HTML too.

Grayside’s picture

Status: Needs review » Fixed

Okay, did some HTML src analysis. Looks good.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

banghouse’s picture

Status: Closed (fixed) » Needs review
86.23 KB

My profile page is still displaying this bug. (See attached image). Not sure if my suggested fix is the right way to go but it does work in Firebug/Chrome Inspector.

Proposed CSS fix is add 1em to margin-top:

.profile dd {
margin: 1em 0 1em 0;
Grayside’s picture

My testing of vanilla OG didn't show that problem... are you suggesting this is an OG problem or should this be moved back to Bluecheese?

drumm’s picture

Status: Needs review » Closed (fixed)
Issue tags: +needs deployment

This hasn't been deployed yet as far as I know. I'm confident it will work since it is making this profile item consistent with others in markup and the way it is implemented. The organic groups project can't do much else for specifically, so moving back to fixed.

drumm’s picture

Issue summary: View changes

Updated issue summary.

drumm’s picture

Issue summary: View changes
Issue tags: -needs deployment