After #1369676: Proposed theme changes to Origins lands, let's implement the following tweaks suggested by noyz:

- Seems like extra spacing between group avatars: https://skitch.com/ezra-g/g416r/our-community-commons-2.4-dev
- Ideally turn tabs into pills, eg https://skitch.com/jeff.noyes/g412m/jeff-noyes-jeff-noyes
- Make "submitted by" text less prominent in the entire theme, per https://docs.google.com/a/acquia.com/document/d/1IqS5vuKsSv0cDwk0vZGxgBM... . Ideally, this would happen with a tooltip per https://docs.google.com/a/acquia.com/leaf?id=0B6CiMWdwdDYJMmFmMmE3ZjYtMj.... Marking the issue as "needs more info" so that noyz can comment.

CommentFileSizeAuthor
#3 origins_tweaks-followup-1412084-03.patch1.53 KBay13

Comments

ezra-g’s picture

ezra-g commented
Status: Active » Postponed (maintainer needs more info)
ezra-g’s picture

ezra-g commented
Status: Postponed (maintainer needs more info) » Active

Let's move " Make "submitted by" text less prominent in the entire theme, per" to a separate issue. Setting this as active for the remaining changes.

ay13’s picture

ay13 commented
Status: Active » Needs review
StatusFileSize
new origins_tweaks-followup-1412084-03.patch1.53 KB

attached patch fixes the first issue and adds the pill tabs for the second issue. i will need some guidance as to the coloring of the tab/pills though. the mock didn't look like it was from the origins theme so didn't know what the styling should be.

lightsurge’s picture

lightsurge commented

I don't really understand the extra spacing between the avatars is an improvement, just adds blank space... I think mainly their weakness is that if a user has no avatar set, they look dull and non-descript.

ay13’s picture

ay13 commented

the problem before was that the cells where not given a width. what would happen is that if there was just 2 members of a group those 2 would take over the width of an area messing up the spacing. by adding a width to the cells of the grid (percentages, 20% for 5 column etc.) every avatar has its own space.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Looks good - thanks!
http://drupalcode.org/project/commons.git/commit/13b967b

ezra-g’s picture

ezra-g commented

I accidentally overwrote the commit in #6 with the main commit for the new group homepage: http://drupalcode.org/project/commons.git/commitdiff/4f63c54a94849c61ba5...

Sorry about that.

I committed this patch again:
http://drupalcode.org/project/commons.git/commit/90169d6

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.