Currently, taxnomy_node_get_terms() only respects the given key the first time it is called for a specific node. The second time, no matter what key is given, it will use the same key. This is because the static variable in which it is cached, is only cached by nid, and not by the key.
Patch is attached. It has a simple and clean solution IMO.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | taxonomy_node_get_terms_key_0.patch | 1.04 KB | wim leers |
| #3 | taxonomy_node_get_terms_key_HEAD_0.patch | 1.08 KB | wim leers |
| #2 | taxonomy_node_get_terms_key_HEAD.patch | 1.06 KB | wim leers |
| taxonomy_node_get_terms_key.patch | 1.02 KB | wim leers |
Comments
Comment #1
chx commentedNice catch but we usually fix HEAD first and port down.
Comment #2
wim leersIn my excitement of finding my very first Drupal Core bug, I forgot to check HEAD first :P But since it's so trivial, here's the patch for HEAD already. Now you can commit both :)
Comment #3
wim leersOops! My superhandy new patch-generating tool did not take the paths into account.
Fixed patch for HEAD attached, 5.1 will follow.
Comment #4
wim leersAnd the updated patch for 5.1.
Comment #5
dries commentedGood catch. Committed to CVS HEAD, but needs to be backported to DRUPAL-5.
(Might be worth it to inspect the other taxonomy_ functions for similar mistakes.)
Comment #6
wim leersSorry for the confusion, but my "5.1 patch" is actually a DRUPAL-5 patch :) So it's there already, in #4.
Comment #7
drummCommitted to 5.
Comment #8
(not verified) commented