here is the missing code.

    $items[] = array(
      'title' => 'Go list',
      'path' => 'admin/build/gotwo', 
      'callback' => '__gotwo_list', 
      'access' => user_access('view entry list'),
    );
    $items[] = array(
      'title' => 'list',
      'path' => 'admin/build/gotwo/list',
      'callback' => '__gotwo_list', 
      'access' => user_access('view entry list'),
      'type' => MENU_DEFAULT_LOCAL_TASK,
      'weight' => -10,
      );
CommentFileSizeAuthor
#10 gotwo.141164.patch2.07 KBspiderman

Comments

jredding’s picture

jredding commented

Released a new version 5.1.1

jredding’s picture

jredding commented
Assigned: Unassigned » jredding
Status: Active » Closed (fixed)

New version fixes this issue.. Closing.

hass’s picture

hass commented
Status: Closed (fixed) » Active

This bug is not fixed in 5.x-1.1. I cannot edit the Go URL List...

jredding’s picture

jredding commented

new code committed which should fix this bug.

jredding’s picture

jredding commented
Status: Active » Closed (fixed)

5.1.2 is working.. All previous 5.x version are completely screwed up due to my limited CVS knowledge

BioALIEN’s picture

BioALIEN commented
Version: 5.x-1.0 » 5.x-1.3
Priority: Critical » Minor
Status: Closed (fixed) » Active

hass, do you think admin/build is the best location for this link? Since it displays stats, I would have imagined it going into the "Logs" section?

Also it needs some help text on the "admin" overview page to make it inline with Drupal. Just a one line description will suffice.

Thoughts?

hass’s picture

hass commented

not sure... good point, but log is not the best location... i'm not awaiting any config there... therefor no good idea to move there. Maybe better to split this in to a config and a log part!? this makes things clean and easy to understand.

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented

i had kinda expected this page to show up under admin/content, or possibly admin/settings, when i first encountered this module- i was very surprised to find it under admin/build, and also don't think admin/logs is the place for it. i like hass' suggestion to split the feature up in two. maybe something like:

  1. admin/(content|settings)/gotwo: all current config info, plus the list of all existing entries for reset/delete ops (as a local task, perhaps?)
  2. admin/logs/gotwo: statistics-only page with click counts, etc.

but i can also see an argument for leaving it where it is (under admin/build), consider it analogous to 'URL aliases', and in fact rename it to 'URL redirects', so it'll be easier to find in there.

in either case, we could also boost the admin/help/gotwo page up a bit, to include some details on how to administer gotwo entries, if the user has perms for that (first place i looked for help) ;)

BioALIEN’s picture

BioALIEN commented

I can see the argument here. Splitting it may overcomplicate the module as an admin would want to reset a link directly after viewing the stats. Therefore, you'd naturally expect to find options such as remove/edit/reset on the same page as these stats.

My +1 goes to keeping it where it is currently and treating it similar to URL aliases. I believe 'URL redirects' sounds a lot more intelligent than 'Go List'. While we're here, I believe we're missing a 1 line description for the administrator overview page (must have show description enabled in admin panel).

Here's what I've added to my dev test in order to also make it give a clue which module this belongs to in case we proceed with 'URL redirects' name change:
Creation and management of 'go' URL redirection to external links on the web.

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented
Assigned: jredding » spiderman
Status: Active » Needs review
StatusFileSize
new gotwo.141164.patch2.07 KB

i've just rolled up a quick patch that adds Bio's text in hook_help, re-adds and re-names the admin/build/gotwo page, and also fixes the admin/build/gotwo/add form, which was also broken. perhaps this should be rolled separately, but they seem related (and minor) enough that i just grouped them together here.

hass’s picture

hass commented
Status: Needs review » Needs work

'URL redirects' is problematic name. We should keep this as is for now - or maybe someone have a better idea. The problem is - "path redirect" module already use this name and is also in 'admin/build' what will confuse people.

All this changes should already be done in latest D6 version.

BioALIEN’s picture

BioALIEN commented

Hmm, what about the following?
1. "Go redirect"
2. "Go redirection"
3. "Go URLs"
4. "Go to URL"

hass’s picture

hass commented

Hm... what about 'Go redirects'? Then we are in the line of the others...

BioALIEN’s picture

BioALIEN commented

Oops, "Go redirect" should have read "Go redirects". Let's go with this name for now :)

hass’s picture

hass commented

Changed the titles in D6 as discussed to "Go redirects".

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented
Status: Needs work » Fixed

I've just updated the above patch to use the Go redirects language as well, and committed to the DRUPAL-5 branch.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.