db_decode_blob is no longer defined in D7

Files: 
CommentFileSizeAuthor
#6 1408312_05_remove_db_decode_blob_function_calls.patch1.54 KBgreggles
PASSED: [[SimpleTest]]: [MySQL] 1,392 pass(es). View
#2 1408312_01_remove_db_decode_blob_function_calls.patch1.42 KBgitesh.koli
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1408312_01_remove_db_decode_blob_function_calls.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

gitesh.koli’s picture

Title: db_decode_blob in profile.views.inc Line#85 needs to be removed. » db_decode_blob function calls need to be removed.
Priority: Normal » Major
gitesh.koli’s picture

FileSize
1.42 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1408312_01_remove_db_decode_blob_function_calls.patch. Unable to apply patch. See the log in the details link for more information. View

attaching the patch for the same.

greggles’s picture

Title: db_decode_blob function calls need to be removed. » fatal error, call to undefined function db_decode_blob - function calls need to be removed.
Version: 7.x-3.0 » 7.x-3.x-dev
Status: Active » Needs review

This is definitely close to right. I'd almost consider it being critical.

Apparently not many people have these views enabled.

bigjim’s picture

Title: fatal error, call to undefined function db_decode_blob - function calls need to be removed. » db_decode_blob function calls need to be removed.
Version: 7.x-3.x-dev » 7.x-3.0
Status: Needs review » Reviewed & tested by the community

Applied the above patch and it worked

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1408312_01_remove_db_decode_blob_function_calls.patch, failed testing.

greggles’s picture

Title: db_decode_blob function calls need to be removed. » fatal error, call to undefined function db_decode_blob - function calls need to be removed.
Version: 7.x-3.0 » 7.x-3.x-dev
Status: Needs work » Needs review
FileSize
1.54 KB
PASSED: [[SimpleTest]]: [MySQL] 1,392 pass(es). View

Same patch, formatted by git diff and applies cleanly to 7.x-3.x-dev.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Well obviously that code could have used test coverage. Oh well.

bigjim’s picture

Yea wasn't an issue for us until we installed 3.3 or -dev

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

Oh another issue which got lost in the issue queue.

Thanks for the patch, just did a short review and committed it to 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.