No comments, badly formatted, etc.

CommentFileSizeAuthor
#1 og.1404790-1.patch28.25 KBGrayside

Comments

Grayside’s picture

Status: Active » Needs review
StatusFileSize
new28.25 KB
Grayside’s picture

Title: OG Module has many non-comformant or missing comment blocks. » og.module has many non-comformant or missing comment blocks.
amitaibu’s picture

+++ b/og.module
@@ -330,6 +343,14 @@ function og_menu_access_unsubscribe($group_node, $account = NULL) {
+ *   Group node object.

Other places you use a better sentence "Node object of the group."

+++ b/og.module
@@ -484,7 +515,11 @@ function og_init() {
+ * Set session variable thats used to determine group context when node is in

thats => that is

+++ b/og.module
@@ -697,16 +739,20 @@ function og_get_group_context() {
+ * ¶

minor: whitespace.

+++ b/og.module
@@ -979,7 +1101,14 @@ function og_list_users_sql($min_is_active = 1, $min_is_admin = 0, $orderby='u.na
+ * @todo
+ *   Use Views for OPML page.

This todo is probably years old. let's remove it :)

+++ b/og.module
@@ -1035,6 +1169,14 @@ function og_view_group(&$node, $teaser = FALSE, $page = FALSE) {
+ * @see og_views_view_group

missing () in the end.

+++ b/og.module
@@ -1212,13 +1366,29 @@ function og_get_node_groups($node) {
+ * @note

I don't think we use @note in Drupal. note that..., is probably enough.

Other than that -- god bless you :)

Powered by Dreditor.

Grayside’s picture

Status: Needs review » Fixed

http://drupalcode.org/project/og.git/commit/aaf02e2

If there are further problems with the comments, please open dedicated issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.