Ice Clean

Sorry you can only have one application in queue (http://drupal.org/node/1354932).
Please close at least one of them.

Feedback from Pareview. You can use this tool yourself.

The most important one: your .info is invalid because of the first line, which negates the next line (with name). If you want an intro message in your .info, you add comments by prepending lines with a ;.

Review of the 7.x-1.x branch:

README.txt is missing, see the guidelines for in-project documentation.
Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting

./iceclean.info: ASCII English text, with CRLF line terminators
./readme.txt: ASCII English text, with CRLF line terminators
iceclean.info
readme.txt
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.


FILE: ...7-pareview/sites/all/modules/pareview_temp/test_candidate/iceclean.info
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | "name" property is missing in the info file
28 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/readme.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
15 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/template.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
7 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: .../sites/all/modules/pareview_temp/test_candidate/templates/block.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
40 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: .../modules/pareview_temp/test_candidate/templates/comment-wrapper.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
29 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: ...ites/all/modules/pareview_temp/test_candidate/templates/comment.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
55 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: ...w/sites/all/modules/pareview_temp/test_candidate/templates/html.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: ...modules/pareview_temp/test_candidate/templates/maintenance-page.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
11 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: .../all/modules/pareview_temp/test_candidate/templates/node--forum.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
75 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: ...w/sites/all/modules/pareview_temp/test_candidate/templates/node.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
75 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: ...w/sites/all/modules/pareview_temp/test_candidate/templates/page.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
65 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: ...sites/all/modules/pareview_temp/test_candidate/templates/region.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
27 | ERROR | File doc comments must be followed by a blank line.
--------------------------------------------------------------------------------

FILE: ...eview/sites/all/modules/pareview_temp/test_candidate/theme-settings.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | File doc comments must be followed by a blank line.
7 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
--------------------------------------------------------------------------------

I also get a whole load of Notices and a few Warnings when I add the theme to my site. (Not even enabled.)

Notice: Undefined index: name in system_sort_modules_by_info_name() (line 925 of /var/www/quadrupal7/modules/system/system.admin.inc).
Notice: Undefined index: name in system_sort_modules_by_info_name() (line 925 of /var/www/quadrupal7/modules/system/system.admin.inc).
Warning: uasort(): Array was modified by the user comparison function in system_themes_page() (line 131 of /var/www/quadrupal7/modules/system/system.admin.inc).
Notice: Undefined index: name in system_themes_page() (line 140 of /var/www/quadrupal7/modules/system/system.admin.inc).
Notice: Undefined index: name in system_themes_page() (line 158 of /var/www/quadrupal7/modules/system/system.admin.inc).
Notice: Undefined index: name in system_themes_page() (line 159 of /var/www/quadrupal7/modules/system/system.admin.inc).
Notice: Undefined index: name in system_themes_page() (line 206 of /var/www/quadrupal7/modules/system/system.admin.inc).
Notice: Undefined index: name in system_themes_page() (line 212 of /var/www/quadrupal7/modules/system/system.admin.inc).
Notice: Undefined index: name in theme_system_themes_page() (line 2708 of /var/www/quadrupal7/modules/system/system.admin.inc).

They're all related to the name error in the .info.

causes errors in Drupal 7.12

Unknown source, but merely going to the theme page with this theme on the system causes the attached errors. It is caused by this theme as removal of the theme fixed the problem, yet adding the Zen theme did not cause errors.

[security] theme settings filtering/validation

facebook and twitter settings are entered into outbound html without verification or filtering.

windows file permissions

The entire repository is executable files. See Changing file permission masks on Windows.

dos file types

A lot of the files are DOS format, please convert to *nix format line endings

coding standards

There are numerous things that do not match the coding standards. See Coding standards. I can't direct you to use Coder module since I don't believe it handles themes all that well, but you could give it a go. It will certainly show you how to fix the CSS and the two non-template PHP files.

git commit messages and attribution

Please refer to Commit messages - providing history and credit about giving yourself some credit and properly formatting commit messages.

left over file

There is a Thumbs.db file in the images directory.

missing files

There are files mentioned in the style.css that do not exist

hard coded paths

/sites/all/themes/iceclean/ should not be included .. the theme can be in a site specific directory

hard coded regions

Some regions have HTML content hard coded into them instead of added dynamically so admin can manipulate them without editing the template files.

hard coded credit

Requiring people to hack the template files to remove the credit if they so desire is not .. desirable. There is a draft set of guidelines here: Guidelines regarding advertising and Drupal projects. If anything, it should be an option in the theme settings, or a block provided by a supporting module.

commented out styles and code

This project is meant to be release ready. If there are bits left over from debugging and creation, please remove them instead of leaving them in the project.

courtesy

This module is based heavily upon the Zen theme, but no longer requires it as a base theme - you should include credit as required by the GPL.

spare template file

node--forum.tpl.php file, but the site would have to be manually configured to create a forum node type to take advantage of this.

support for site settings

not all the site settings have been included, like footer message. Also site slogan div is included regardless of it's value being set or not.

This sounded familiar to me so I looked up the other projects you have been working on. Ice Blue and Ice Business. The later of those two is a full project. Both of these projects show a misunderstanding of the theme system. There is hard coded javascript, static html and even cycling images in the template files. What is being done in these themes is simply not meant to be done at the theme layer, and especially not directly in the template files. Some of this functionality should be in the preprocess functions, but a lot would be much better off in a custom support module, or perhaps with a features module. Or left up to the site builder and the theme just wrap them.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

add live demo site address