_filter_xss_attributes is a bit hard to read because things aren't setup at the top but in the middle of the code.

This patch adds a sane default value for $skip.

CommentFileSizeAuthor
#10 xss-skip-default-1398044-10.patch481 bytesbradwade
#3 drupal-skip_default-1398044-3.patch481 bytesistryker
#1 1398044-skip-default.patch371 bytesdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1398044-skip-default.patch371 bytes

So here is the patch, it's definitive really minor.

istryker’s picture

istryker commented
Status: Needs review » Reviewed & tested by the community

This is a very old patch.

> git apply -v --index 1398044-skip-default.patch
Checking patch core/includes/common.inc...
Hunk #1 succeeded at 1124 (offset -334 lines).
Applied patch core/includes/common.inc cleanly.

Patch is good and doesn't break anything.

istryker’s picture

istryker commented
Title: Provide default value for $skip in _filter_xss_attributes » Provide default value for $skip in XSS Component
Status: Reviewed & tested by the community » Needs review
Issue tags: +Novice
StatusFileSize
new drupal-skip_default-1398044-3.patch481 bytes

May 28th, #1998466: Convert filter_xss_admin and similar function to an Xss component was committed which broke this patch. Re-rolling...

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Cool.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice

The last submitted patch, drupal-skip_default-1398044-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

#3: drupal-skip_default-1398044-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-skip_default-1398044-3.patch, failed testing.

istryker’s picture

istryker commented
Status: Needs work » Needs review
Issue tags: +Novice

#3: drupal-skip_default-1398044-3.patch queued for re-testing.

bradwade’s picture

bradwade commented
Assigned: Unassigned » bradwade

Will reroll

bradwade’s picture

bradwade commented
StatusFileSize
new xss-skip-default-1398044-10.patch481 bytes

Rerolled #3

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Category: feature » task
Status: Reviewed & tested by the community » Fixed

Looks good to me. Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.