IF condition always evaluate to true :(

CommentFileSizeAuthor
seven.patch826 bytesdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tamanna-freelancer’s picture

Status: Needs review » Reviewed & tested by the community

I have tested this patch and it works fine.

xjm’s picture

Status: Reviewed & tested by the community » Needs review

Thanks for the patch! Kinda not sure about the form of this fix, though. I don't think it's backportable, either. See:

I think we need more review on the approach here, at least.

David_Rothstein’s picture

Status: Needs review » Needs work

So is this issue actually a duplicate? It seems like the first part of the patch is being covered in #997408: $tabs is always set and the second part in #953034: [meta] Themes improperly check renderable arrays when determining visibility...

-      <?php if ($page['help']): ?>
+      <?php if (isset($page['help']['system_help']['content'])): ?>

This will break if you have other blocks in the 'Help' region, or if you're using something other than the Block module to manage your page regions.

bleen’s picture

Title: Remove empty HTML markups » Remove empty HTML tags

fixing title ...

xjm’s picture