Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
locale.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Dec 2011 at 16:45 UTC
Updated:
4 Jan 2014 at 01:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerHere is a xhprof screenshot + a patch
Comment #2
dawehnerAdd tag
Comment #3
droplet commentedmore discuss: #1135950: Remove static caching in t()
Comment #4
dawehnerThe other issue is about the static in t() this one about the one in locale(), this seems to be fundamental different places
Comment #5
kars-t commentedThis patch is an exact copy of what is done in user_access()
So as this is in core I'd say code wise it is good.
On the performance side I did test this on our biggest site and added some xhprof screenshots as well. It's over 2.500 calls to drupal_static() we can cut away with this in my environment.
Standard Drupal Core
Patched Drupal Core
Comment #6
catchLooks good, thanks for the xhprof screenshots :)
Committed/pushed to 8.x.
Moving for backport just in case.
Comment #7
dawehnerHere is a patch for 7.x
Comment #9
dawehnerUpdate status
Comment #10
kars-t commentedVery same patch as in D8 except the file path. So I set this again to RTBC.
Comment #11
webchickFancy pants. :)
Committed and pushed to 7.x. Thanks!
Comment #12
dawehnerAwesome!
Thanks for committing the patch!