While using RTL direction, when displaying a node links in the bottom are not aligned on the left.
Here is the problem:
display link error
This is the fix:
display link fix

CommentFileSizeAuthor
#5 rtl-display-link-1387572-drupal8.patch337 bytespbull
#2 rtl-display-link-1387572-2.patch317 bytespbull
#1 rtl-display-link-1387572-1.patch316 bytespbull
#1 2012-01-06_2341.png26.05 KBpbull
rtl-display-link.patch360 bytestarekdj
display-link-fix.png25.61 KBtarekdj
display-link-error.png28.58 KBtarekdj

Comments

pbull’s picture

pbull commented
StatusFileSize
new 2012-01-06_2341.png26.05 KB
new rtl-display-link-1387572-1.patch316 bytes

Patch applies cleanly and fixes the RTL issue in FF 7, Chrome 16.

However in Safari 5, longer lists of links wrap prematurely, as seen here:
Safari 5 RTL wrapping

Replacing the proposed CSS with .link-wrapper { text-align:left; } fixes this across all tested browsers. Re-rolling and attaching revised patch.

pbull’s picture

pbull commented
StatusFileSize
new rtl-display-link-1387572-2.patch317 bytes

Fixing whitespace.

tarekdj’s picture

tarekdj commented
Status: Needs review » Reviewed & tested by the community

Patch works fine! seems to be RTBC for me

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 7.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice, +Needs backport to D7

Thanks for the patch! This needs to be fixed in Drupal 8 first per the backport policy. (We'll fix it in Drupal 7 around the same time.) Could we get a version of the patch rolled against Drupal 8?

pbull’s picture

pbull commented
Status: Needs work » Needs review
StatusFileSize
new rtl-display-link-1387572-drupal8.patch337 bytes

D8 patch attached.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice

Perfect, thanks!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x and back-ported to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.