Before (notice the logo overlaps the content):
before

After adding the following to the stylesheet:

body.in-maintenance #logo {
    width:180px;
}

We get the correct size logo:
after

CommentFileSizeAuthor
#10 seven-logo-mant-1384224-10.patch330 bytesoriol_e9g
#5 resize-logo-1384224-5.diff350 bytesphilbar
#3 resize-logo-1384224-3.diff635 bytesphilbar
#2 resize-logo-1384224-3.diff330 bytesplazik
#1 resize-logo-1384224-2.diff326 bytesphilbar
Screen Shot 2011-12-24 at 9.30.32 PM.png39.89 KBphilbar
Screen Shot 2011-12-24 at 9.30.13 PM.png41.06 KBphilbar

Comments

philbar’s picture

philbar commented
Title: Maintanance Theme should Re-size Site Logo » Resize Site Logo in Seven Theme Maintanance Pages
Status: Active » Needs review
StatusFileSize
new resize-logo-1384224-2.diff326 bytes
plazik’s picture

plazik commented
StatusFileSize
new resize-logo-1384224-3.diff330 bytes

What happens if the logo smaller than 180px?
It's should be max-width instead of width.

philbar’s picture

philbar commented
StatusFileSize
new resize-logo-1384224-3.diff635 bytes

max-width is not supported in IE6. Adding fallback to ie6.css.

droplet’s picture

droplet commented
Version: 7.10 » 8.x-dev
Status: Needs review » Needs work

#2 looks good. can you reroll it for D8 first.

ummm. drupal is missing a good logo function, our logo are no dimension values.

philbar’s picture

philbar commented
StatusFileSize
new resize-logo-1384224-5.diff350 bytes

Patch rerolled against 8.x.

Note: this doesn't support IE6, which isn't a problem since it isn't supported in 8.x.

philbar’s picture

philbar commented
Status: Needs work » Needs review
droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

This indeed looks good to go.

That said, I wouldn't bother with IE6 in the backport for D7 (it only supports width and that would break all logos that happen to be smaller).

catch’s picture

catch
he/him
Primary language English
commented
Title: Resize Site Logo in Seven Theme Maintanance Pages » Resize Site Logo in Seven Theme Maintenance Pages
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 8.x.

Moving back to 7.x for backport.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new seven-logo-mant-1384224-10.patch330 bytes

As comment @sun ported without IE6 specific code.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks.

konichiwa50’s picture

konichiwa50 commented

this is very nice.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Ick! Nice fix. Sounds like IE6 just ignores this so it won't look more ugly there than it does without the patch.

Committed and pushed to 7.x. Thanks! :)

Automatically closed -- issue fixed for 2 weeks with no activity.