As stated in the documentation: Choosing the proper name for your functions is very important.
So, it would be nice to rename $values variable in standard_install().

CommentFileSizeAuthor
#1 quick_fix-1382144-0.patch1.04 KBchi

Comments

chi’s picture

chi commented
Title: Rename $values variable in standart profile » Rename $values variable in standard profile
Status: Active » Needs review
StatusFileSize
new quick_fix-1382144-0.patch1.04 KB
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7

Good improvement to code readability.

Patch looks good to me & the bot likes it, so RTBC.

(And can we backport it too, as it's variables purely internal to a function?)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yeah, seems like a pretty harmless clean-up to me.

Committed and pushed to 8.x and 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.