According to steps from instructions:

1. A detailed description of what project does:
This module provides Liqpay payment (popular in some Europe countries and in Russia) through liqpay.com website, when using Drupal Commerce.
Full descriptions and instructions: http://drupal.org/sandbox/InternetDevels.com/1378668

2. A link to project page:
http://drupal.org/sandbox/InternetDevels.com/1378668

3. A direct link to git repository:
git clone --branch master http://git.drupal.org/sandbox/InternetDevels.com/1378668.git

4. Drupal 7 only

Comments

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

Looks like you already know ventral.org/pareview
Please fix these issues (http://ventral.org/pareview/httpgitdrupalorgsandboxinternetdevelscom1378...) first and switch back to 'needs' review.

If you got any questions on this, please ask!

internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review

We have already fixed all warnings and notices:
http://ventral.org/pareview/httpgitdrupalorgsandboxinternetdevelscom1378...

Thanks for your advice.

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

But, you are still working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review

Thank you, patrickd.

I created 7.x-1.x dev branch and cleaned out the master branch.

internetdevels’s picture

internetdevels commented

Also I have done demonstration site:
http://commerce-liqpay.internetdevels.com

here everyone could test that module works correctly

internetdevels’s picture

internetdevels commented
Priority: Normal » Critical

Updating priority according to http://drupal.org/node/894256

internetdevels’s picture

internetdevels commented

The new url of demonstration site is:
http://demos.internetdevels.com/commerce-liqpay/

operinko’s picture

operinko commented
Status: Needs review » Needs work

http://ventral.org/pareview/httpgitdrupalorgsandboxinternetdevelscom1378668git

You still have some indentation issues in the .module file. Those should be fixed.

Also, why is the "Failed status" necessary? If the payment failed, I wouldn't even consider marking the transaction as "Pending" or "Success".
Same question for the "Success status" and "Waiting status". Those, as far as I'm concerned, should always be COMMERCE_PAYMENT_STATUS_SUCCESS and COMMERCE_PAYMENT_STATUS_PENDING respectively.
I can see some sense in using custom messages for those, but the custom status eludes me.

Apart from those, couldn't find anything wrong in the code (but being lazy, I didn't register for a LiqPay account to test it further).

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.