Revealed via #1373142: Use the Testing profile. Speed up testbot by 50%

Problem

  • Tests in simpletest.test are not contained in the UI list/overview of available tests to run at all.

Note: The testbot has no issues with detecting and running the tests in this file. They were just not exposed in the SimpleTest group in the UI (except for one being located in another .test file).

Attached patch is a stop-gap fix, does not fix the underlying issue. I suspect a bug in the class registry parser.

Files: 
CommentFileSizeAuthor
#12 simpletest-description-1376164-12.patch985 bytesoriol_e9g
PASSED: [[SimpleTest]]: [MySQL] 37,293 pass(es).
[ View ]
#6 drupal8.simpletest-tests.6.patch1005 bytessun
PASSED: [[SimpleTest]]: [MySQL] 34,231 pass(es).
[ View ]
#3 drupal8.simpletest-tests.3.patch1006 bytessun
PASSED: [[SimpleTest]]: [MySQL] 34,241 pass(es).
[ View ]
drupal8.simpletest-tests.0.patch1.13 KBsun
PASSED: [[SimpleTest]]: [MySQL] 34,240 pass(es).
[ View ]

Comments

xjm’s picture

Status:Needs review» Reviewed & tested by the community

I think this is totally appropriate as a quick fix (edit: since escaped quotes are ugly anyway), so long as we open a followup issue to actually track down the parser issue.

Dave Reid’s picture

Agreed. RTBC.

sun’s picture

StatusFileSize
new1006 bytes
PASSED: [[SimpleTest]]: [MySQL] 34,241 pass(es).
[ View ]

Removed the @todo.

David_Rothstein’s picture

Status:Reviewed & tested by the community» Needs work

"simplicitly"??

I also don't think the @todo is necessary; the new version is using correct code style and the old one wasn't, so there's no reason to ever switch it back.

David_Rothstein’s picture

Oops, crosspost, but the "implicitly" => "simplicitly" change is still in there.

David_Rothstein’s picture

d.o hiccup

sun’s picture

Status:Needs work» Needs review
StatusFileSize
new1005 bytes
PASSED: [[SimpleTest]]: [MySQL] 34,231 pass(es).
[ View ]

Fixed "implicitly."

xjm’s picture

Title:SimpleTest tests do not appear in list/overview of tests (class registry parser bug?)» Format SimpleTestFunctionalTest description according to standards

So I can't reproduce the test not being listed with a fresh install of D8; I'm wondering if the functional bug was a registry caching issue from pulling new changes into an existing D8 install.

I still think the reformatting is good, though, so retitling for scope.

David_Rothstein’s picture

Status:Needs review» Reviewed & tested by the community
webchick’s picture

One other annoying grammar thing: It should be APIs rather than API's. http://theoatmeal.com/comics/apostrophe Can be fixed prior to commit.

But channeling catch, I believe he would want to see the follow-up issue to get to the bottom of the root cause of this cross-linked here prior to commit. :)

catch’s picture

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Yeah I would, but I also want tests to be 45% faster, so I opened it at #1379940: Track down registry and/or simpletest parser issue that was fixed by some formatting changes :)

Committed/pushed to 8.x (as well as a sneaky follow-up).

sun’s picture

Actually, I was no longer able to reproduce this bug. Someone else in IRC (not sure whether it was @xjm) was able to reproduce it like me at the beginning, but then also not anymore. Mysterious! :)

Since this only affected SimpleTest UI and at least the testbot did not skip those tests (which is how I discovered it when I wanted to run the failing tests locally), and because no one is able to reproduce it currently, I'm going to close the other issue.

The string formatting fix can still be backported though.

oriol_e9g’s picture

Status:Patch (to be ported)» Needs review
StatusFileSize
new985 bytes
PASSED: [[SimpleTest]]: [MySQL] 37,293 pass(es).
[ View ]
sun’s picture

Status:Needs review» Reviewed & tested by the community
webchick’s picture

Status:Reviewed & tested by the community» Fixed

Ok, seems like fine in terms of consistency, then.

Committed and pushed to 7.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

cweagans’s picture

cweagans’s picture

Issue summary:View changes

Clarified summary.