Problem/Motivation

Proposed resolution

  • Add an additional paragraph above the @param documentation of QueryConditionInterface::condition() with the following text:

    Do not use this method to test for NULL values. Instead, use QueryConditionInterface::isNull() or QueryConditionInterface::isNotNull().

  • Add @see lines at the bottom of the docblock to QueryConditionInterface::isNull() and QueryConditionInterface::isNotNull().

Refer to the doxygen standards for details on the formatting.

Remaining tasks

  • Create a patch with the above documentation changes for Drupal 8.

User interface changes

  • None.

API changes

  • None.

Comments

xjm’s picture

Assigned to me for now.

xjm’s picture

Issue summary: View changes

Updated issue summary.

xjm’s picture

Issue summary: View changes

Updated issue summary.

jhodgdon’s picture

Technically, no patch is supposed to get into D8 without the accompanying doc being fixed too. This should really not be a separate issue. See the Gates page:
http://drupal.org/core-gates

Sigh.

xjm’s picture

Component: documentation » database system

Switching components on account of #2.

ayelet_Cr’s picture

Assigned: xjm » ayelet_Cr
Status: Active » Needs review
StatusFileSize
new1007 bytes

Here is a patch.

xjm’s picture

Status: Needs review » Reviewed & tested by the community

#4 looks good to me. Thanks @ayelet_Cr!

catch’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 8.x, moving to 7.x.

oriol_e9g’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new987 bytes

D7 roll

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.