Was at a loose end this evening, so I've gone through the entire codebase removing all trailing whitespace.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sammyd56’s picture

Status: Active » Needs review
FileSize
81.71 KB
dawehner’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Great! Thanks for your contributions!

I had some fears about whitespaces in regions which are changed by other patches, but as these whitespace fixes
are mostly in css files and html files, which aren't changed that often this shouldn't be a problem at all.

Committed to 7.x-3.x

I would be happy if you would like to backport these changes to 6.x-3.x as well. Do you use some kind of automatic tool for that?

sammyd56’s picture

Status: Patch (to be ported) » Needs review
FileSize
187.4 KB

I have a gedit plugin that removes trailing whitespace when saving files.

It's really handy, but also a bit annoying, because when you make a patch to a file that already contained whitespace you end up including unrelated whitespace fixes and have to remove them from the patch.

So, I figured I could save people some time by opening all the files one by one and resaving them, thus stripping the whitespace.

Being a PHP novice I can't help with real coding at the moment, but at least I can help with something and show my appreciation to Drupal developers.

Here's a patch for 6.x-3.x.

dawehner’s picture

Status: Needs review » Fixed

Your work is highly welcomed!

You know 2.5 years ago i started with patches like that and now i have the pleasure to help out with this module on daily base.

There will be no fixed for 6.x-2.x anymore, because it's a REAL stable version :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.