Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Commerce customizable products adds another way to add line item types as an alternative of CCLI, we need to add support to that.
Probably is just taking care of the revert action.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1369688-line-item-types.patch | 4.48 KB | bojanz |
| #2 | commerce_features-custom_products_support-1369688-2.patch | 1.34 KB | jeffschuler |
| #1 | commerce_features-custom_products_support-1369688-1.patch | 1.34 KB | jeffschuler |
Comments
Comment #1
jeffschulerFirst pass.
Needs a few more eyes and a sanity check, but it's working for me so far. :)
Comment #2
jeffschulerI had the two modules' logic swapped. Apparently hadn't tested features-reverting.
Comment #3
bojanz commentedRerolling / redoing.
Comment #4
bojanz commentedWe want to remove the support for the deprecated Commerce Custom Line Items module.
We also want to handle only the types managed by Commerce Customizable Products, instead of handling all defined line item types.
That matches the logic change we did with product types prior to beta1.
This is completely untested.
Depends on a patch for Commerce Customizable Products: #1732696: Improve API to allow exporting by commerce_features.
Comment #5
pcambraThat's exactly what I wanted to comment out here, but not sure how many people is still using CCLI with this integration, which will completely dissapear after this patch.
Comment #6
jeffschulerMaybe features support could be moved into CCLI, directly?
Comment #7
bojanz commentedCCLI won't be getting any new commits. It's been dead for a long time.
That's why I can't bring myself to care much about dropping CCLI support.
Those who can't migrate can just stay with commerce_features beta1.
Comment #8
pcambraAgreed on CCLI support, whoever wants this can either use beta1 or replace the line items component of the next version by the one in beta1.
I've tested this and make some fixes on how we were getting the data, committed, thanks both!