According to the interface documentation: http://api.drupal.org/api/drupal/modules--system--system.queue.inc/funct...

createItem() should return TRUE if the item was added to the queue.

MemoryQueue::createItem does not do this.

CommentFileSizeAuthor
#9 memoryqueue-createitem-1364694-9.patch416 bytesbanviktor
#4 memoryqueue-createitem-1364694-4.patch784 bytesgielfeldt
#1 memoryqueue-createitem-1364694-1.patch807 bytesgielfeldt

Comments

gielfeldt’s picture

gielfeldt commented
Status: Active » Needs review
StatusFileSize
new memoryqueue-createitem-1364694-1.patch807 bytes

Status: Needs review » Needs work

The last submitted patch, memoryqueue-createitem-1364694-1.patch, failed testing.

gielfeldt’s picture

gielfeldt commented

"#¤"#¤#¤&#¤!"#/&%&/%& ... now what?!?

Can someone guide me to the docs for creating patches for Drupal core? Can't seem to find it...

gielfeldt’s picture

gielfeldt commented
Status: Needs work » Needs review
StatusFileSize
new memoryqueue-createitem-1364694-4.patch784 bytes

Ah, RTFM...

gielfeldt’s picture

gielfeldt commented

Status? This patch is still valid.

banviktor’s picture

banviktor commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Ran into the same issue. Patch still applies to 7.x and fixes the problem. Thank you gielfeldt!

fabianx’s picture

fabianx commented
Issue tags: +Pending Drupal 7 commit, +Needs reroll

This is fixed in D8.

Marking for commit, nice catch!

Needs a re-roll though so it can be re-tested.

I don't think we need tests for this as it is fixed in D8.

banviktor’s picture

banviktor commented
Issue tags: -Needs reroll

Rerolled so this issue doesn't get stuck again. All credits go to @gielfeldt.

banviktor’s picture

banviktor commented
StatusFileSize
new memoryqueue-createitem-1364694-9.patch416 bytes

Whoops forgot to upload.

fabianx’s picture

fabianx commented

Thank you!

stefan.r’s picture

stefan.r commented

This should be fine to commit without tests, the interface is clear, and testing that it returns TRUE seems a bit silly.

  • Fabianx committed 09de859 on 7.x 
    Issue #1364694 by gielfeldt: MemoryQueue::createItem does not return...
fabianx’s picture

fabianx commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

fabianx’s picture

fabianx commented
Issue tags: -Pending Drupal 7 commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.