Hey, first off this is a FANTASTIC plugin so thank you thank you.

Seems to work great. The only thing I noticed is that I had a node with a title (which was the sorting criteria) that started with "35mm blah blah". I guess Alpha Pager choked on that beause I got a pager that looked like:

0 A B C D E F (etc)

where the letters were BLACK (ie, not links) and the only node that showed up was the "35mm" titled node. I don't know why it said "0" and not "3" but I haven't peered to closely to the code.

Anyway, a solution might be to make a link called "#" or "other" or something for all non-alphabetically sorted nodes. I have no idea what to do for non-english node fields... that could be tricky to even know what a "letter" consists of in say, chinese or something.

Anyway, a fix for the non-numeric english would be great. Thanks!

W

CommentFileSizeAuthor
#5 Picture 1_38.png7.49 KBVValdo

Comments

douggreen’s picture

douggreen commented

I display "0" for all numbers and "_" for all punctuation. I agree that "#" would probably make more sense.

When alpha pager is first called, it returns the first set of nodes. If the first article starts with an "C" then you'll get back all of the "C" nodes. If the first article starts with a number, you'll get back all of the node that start with a number. This is by design. So, the fact that you're getting back the 35mm node and that's all, is by design.

However, the alpha letters should be links. I don't know why this is happening. If the 35mm node isn't in the result set, do the alpha links display? You can test this by unpublishing the node and then adding the "Node: Published" filter to the view.

VValdo’s picture

VValdo commented

Well, what i did was delete the node, and suddenly everything worked, which lead me to expect that the module wasn't properly handling numbers. I don't know why not only the "0" link but all the links were plain black and not actual working links. I can investigate this a little more but it will mean some work (I'd have to roll back to the previous db before I killed that "35mm" one.. or try to recreate it) so this may take a few days.

I think the "#" may be a little clearer as I though it was a bigger bug than it was, since the node title started with at 3 but the link was a "0"...

Thanks. I love this module and would love to see it make it to Views proper :)

W

diegogers’s picture

diegogers commented

I'm having the same issue, here is part of the output, i have a couple of nodes beggining with numbers, and al the letter of the pager are just black...

<div class="apager"><span class="pager-list"><strong class="pager-current">0</strong>  <strong class="pager-current">A</strong>  <strong class="pager-current">B</strong>  <strong class="pager-current">C</strong>  <strong class="pager-current">D</strong>  <strong class="pager-current">E</strong>

nice module, btw

douggreen’s picture

douggreen commented

You'll have to do some debugging, or provide a test case. If it was me, I'd add a few print statements in theme_alpha_pager() to see what $current and $items (and maybe $item) are set to. At the top of the function, try adding the following code:

  print "current=$current, items=";
  print_r($items);

Paste the results back here, BUT PLEASE use your browser's "View Source" feature, copy the results from the source, then paste it back here between the tags <code> and </code>. Do not copy the results from the browser directly as that will create an unformatted string that takes 10 times longer for me to view.

VValdo’s picture

VValdo commented
StatusFileSize
new Picture 1_38.png7.49 KB

I added your code and this is what I received:

current=0, items=Array
(
    [0] => 0
    [A] => A
    [B] => B
    [C] => C
    [D] => D
    [E] => E
    [F] => F
    [G] => G
    [H] => H
    [I] => I
    [K] => K
    [L] => L
    [M] => M
    [N] => N
    [O] => O
    [P] => P
    [Q] => Q
    [R] => R
    [S] => S
    [T] => T
    [U] => U
    [V] => V
    [W] => W
    [Y] => Y

Hope this helps. Here is also an attachment showing the problem. In this case there is only one node displayed, with a title starting with "35mm"..

W

douggreen’s picture

douggreen commented

The problem appears to be related to comparing as numbers instead of strings. Please try changing == on line 241 to ===. If this fixes it, then report back, and I'll patch the module.

Index: views_alpha_pager.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/views_alpha_pager/views_alpha_pager.module,v
retrieving revision 1.5.2.15
diff -u -r1.5.2.15 views_alpha_pager.module
--- views_alpha_pager.module    16 Apr 2007 13:14:04 -0000      1.5.2.15
+++ views_alpha_pager.module    25 Apr 2007 17:17:08 -0000
@@ -238,7 +238,7 @@
   if (!empty($items)) {
     $output .= '<div class="apager"><span class="pager-list">';
     foreach ($items as $item) {
-      if ($item == $current) {
+      if ($item === $current) {
         $output .= '<strong class="pager-current">'. $item .'</strong> ';
       }
       else {
VValdo’s picture

VValdo commented

Fixed!

:)

Thx,

W

VValdo’s picture

VValdo commented

Oh, while you're patching, I think "#" makes more sense than "0" for all non-alphabetic characters... I had thought that "0" for "35mm" was a bug.

W

douggreen’s picture

douggreen commented

I've checked a new version in as the 5.x-dev. Could you please test with this. I also changed the 0 to a #, you weren't the first person to complain about this.

douggreen’s picture

douggreen commented
Status: Active » Fixed

I think this is fixed, please re-open if you still have problems. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
slidescanner’s picture

slidescanner commented

This is what I was looking for. Thanks for the fix!

35mm slide scanner

lpn online’s picture

lpn online commented

thanks for this amazing piece of code - exactly what I was searching for.
lpn online, zoo coupons

nikon monarch’s picture

nikon monarch commented

a very useful code indeed

lpn online’s picture

lpn online commented

great resource !

mercury barometer
barometers