There's an unused variable, $header, in template_preprocess_views_view_table() in ./theme/theme.inc. It's initialised to an empty array and then never used.

CommentFileSizeAuthor
#2 fix-patch-for-318944-1362114-2.patch395 bytesJamesAn
#2 fix-patch-for-318944-1362114-2-6.x-3.0-rc3.patch428 bytesJamesAn

Comments

JamesAn’s picture

JamesAn commented
Status: Active » Needs review

I traced it to the patch submitted in #318944-15: Table style crashes when no fields are visible due to permissions.. It's meant to fix the situation where the $vars['header'] in template_preprocess_views_view_table() never gets set when the user doesn't have permissions to view any of the fields. In the table template, referencing $header would throw an error since it isn't set.

Instead of $header = array();, I think the fix should've been $vars['header'] = array();.

This affects 6.x-3.0-rc3 as well.

JamesAn’s picture

JamesAn commented
StatusFileSize
new fix-patch-for-318944-1362114-2-6.x-3.0-rc3.patch428 bytes
new fix-patch-for-318944-1362114-2.patch395 bytes

Patch for 7.x-3.0-rc3 and 6.x-3.0-rc3.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Just removed this variable as it's defined above.

Thanks for reporting the issue, committed that to 6.x-3.x and 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.