mollom/%/% pollutes the top-level "mollom" namespace in terms of system paths, which ain't good.

Especially, in case we're going to move the inbound moderation code into a sub-module.

This is major, as the default endpoints cannot be changed easily later on (only determinable by module release version, if any).

CommentFileSizeAuthor
#4 mollom.maas-endpoint.4.patch495 bytessun
mollom.maas-endpoint.0.patch480 bytessun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed to 7.x-2.x.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Patch (to be ported) » Needs work 
+++ b/mollom.module
@@ -157,8 +157,7 @@ function mollom_menu() {
-  $items['mollom/%/%'] = array(
+  $items['mollom/moderate/%/%'] = array(
...
     'page arguments' => array(1, 2),

Gosh, you're getting old, eh?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.maas-endpoint.4.patch495 bytes
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Change in #4 has been incorporated into the follow-up patch of #903770: Integrate with Mollom moderation

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Patch (to be ported) » Fixed

Backported, committed, and pushed to 6.x-2.x via #1379136: Backport recent changes in 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 74ea633 on 7.x-2.x, fai6, 8.x-2.x, fbajs, actions by sun: 
    - #1361320 by sun: Change inbound moderation endpoint to mollom/moderate...

  • Commit 74ea633 on 7.x-2.x, fai6, 8.x-2.x, fbajs, actions by sun: 
    - #1361320 by sun: Change inbound moderation endpoint to mollom/moderate...