taxonomy_menu passes invalid arguments into taxonomy_form_term()

At first I was a little unclear on why this was necessary, but eventually I figured out it's because taxonomy_form_term() takes two arguments past $form and $form_state - one for the term, the other for the vocabulary. The menu router entry should specify both those arguments, but it currently only specifies the term.

This should be easy to write a test for, also the menu entry could use a comment as to why we're specifying NULL there.

Yep.

It took me a few minutes to wrap my head around this as well. The extra argument it's expecting is the vocabulary machine name, for when the form builder is reused for:
admin/structure/taxonomy/%taxonomy_vocabulary_machine_name/add
(Added in #604980: taxonomy_term_edit() is useless.)
So despite that the argument for the function defaults to NULL, it has to be specified anyway in the menu hook to get around the feature that additional path components get passed in as additional args.

Edit: Never mind about that last bit; local environment problem. :P

Here's a test for it. As a bonus, a message you don't see every day.

Oh, I missed where catch asked for a comment. Not sure how to say it concisely. How about:

Ensure that additional path components are not passed to taxonomy_form_term() as the vocabulary machine name argument.

Would that be sufficient? The API doc and signature for taxonomy_form_term() should explain the rest.

Incorporating #15.

Actually maybe this is a bit more clear.

Thanks, looks good.

(yet another reason to use more query string parameters in Drupal)

The new test and comment look good. committed/pushed to 8.x, moving back to 7.x, will need a quick re-roll.

Committed and pushed to 7.x. Thanks!