Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Nov 2011 at 16:24 UTC
Updated:
29 Jul 2014 at 20:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Sree commentedI am open to update this & provide the patch
Comment #2
xjmHi @Sree,
Thanks for taking this on. Are you still working on this issue? If not, we'll unassign it in a day or two so that someone else can give it a try. (Feel free to assign it back to yourself if you'd still like to work on it, as well.) Thanks!
Comment #3
30equals commentedHi there,
I came across this issue, and thought i'd supply a basic batch. I added a simple function body to illustrate the hook.
I hope it's sufficient like this :)
Comment #4
marvil07 commentedPatch looks good, it's a simple example and it does not really need any extra comments since the output message explain it.
I would say it's ok.
Comment #5
tim.plunkettShouldn't this be in t()?
-22 days to next Drupal core point release.
Comment #6
marvil07 commentedComment #7
jhodgdonUm... This is for hook_node_type_insert(), not hook_node_type_update(), right? In which case, I don't think there is an "old type"?
Comment #8
marvil07 commentedI need to pay more attention :-p
Comment #9
jhodgdonThat's better. :) It's not a very useful sample function body, but I guess it gets the point across.
Comment #10
dries commentedIt is a bit confusing that the machine name is $type but I'm okay with this example.
Comment #11
jhodgdonWell, that is what the content type object's field name is... I think the example is clear enough, since it says "with machine name %type", but it would be easy enough to change it to %machine_name, which would definitely get rid of all confusion...
Comment #12
marvil07 commentedComment #13
jhodgdonRTBC again, thanks! :)
Comment #14
dries commentedCommitted to 7.x and 8.x. Thanks!
Comment #15
marvil07 commentedIt seems like the patch included on both 7.x and 8.x was the one on comment 8(not the one on comment 12).
Was it a mistake? If so, please re-close again.
Comment #16
dries commentedThis was on purpose. Sorry for not being more clear.
Comment #17
xjmSo what was the reasoning for using #8 instead of #12?