Forward-port upgrade test clean-ups from 7.x to 8.x

I should be able to start taking a look at this Monday onwards (*maybe* over the weekend though never a guarantee on that). Other things that would probably help with making the D8 tests more viable would be to have a similar style of dumps to what we have for D7. This means a standard profile + all modules installation, and a minimal profile installation dump (bare and filled variants). We need to update the dumps that are there to be reflective of the current set of changes for D7 anyways. That aspect is one of the more time consuming tasks.

Ok, I'll get started on this soon (I am figuring out a way to speed up the whole dump generation aspect since its a PITA) and time to figure out what was written :)

Attaching a patch which first gets rid of the current set of dumps and replaces them with what is currently in Drupal 7.9 (which looks like it'll be outdated in a few days). Naturally, a lot more needs to go in but with the dumps out of the way, it will be easier to concentrate on the issue.

Changing to needs review just to make sure the light stays yellow.

Ok, new patch since I had not used git rm to remove the old php.gz files that were there.

Should have actually attached a patch...

...and marking as needs review just to make sure the current patch is holding up.

Ok, first real stab at the cleanup. New dumps, reorganized to be more like how it was done for 7.x.

Needs to get retested since #1273478: Implement @requires and @dependencies within TestBase, mark tests as skipped got committed. So ... #9: 1352000_9.patch queued for re-testing.

Rerolled version of patch. Hopefully didn't miss anything :)

Realized I forgot to un-assign myself from the issue so someone might actually take a look at it :)

#12: 1352000_11.patch queued for re-testing.

#12: 1352000_11.patch queued for re-testing.

This is arguably a regression, and it's blocking #1263208: Upgrade path for blog module removal, bumping to critical.

Would you be able to specify how it is a regression? A better understand will help me in trying to clean up the code. As far as forward ports go, the functionality is identical with 7.x. I'll see where I can get with whatever is causing the failures.

It's a regression in the sense that 8.x is behind 7.x at the moment, I was mainly trying to find excuses to bump the priority in the hope more people would review it / help out ;)

Ok, assigning to myself again. Hopefully, I can get something up and running again before leaving work.

This test is going to fail on the language related tests so that needs to get fixed up (so it seems that #1263208: Upgrade path for blog module removal may be blocking this instead? Have to look into it more) but its still worth for someone to review and give feedback. I didn't make changes to the generate-d7.sh file as we did for D7 since the generate script has been updated for both D7 and D8 from another issue.

Combining with the latest patch done at #1263208: Upgrade path for blog module removal since the language php dump is causing issues due to duplicate data. That def. needs a review but things *should* pass.

Adding actual patch...

#24: 1352000_23.patch queued for re-testing.

Anyone else want to tackle it? Its surprising that for a critical issue, no one else has bothered to even review it over the 4 rerolls that have had to occur due to changes in the rest of Drupal.

I feel a roadmap is needed to get this issue completed.

Due to frequent db schema changes pulling the rug out from under this patch, perhaps it's time to 'organize' this largish patch for "quick" review, test, and commit to core? By a group of us, in a 1-2 day period, so the rug is not pulled out again?

I asked BTMash to itemize this patch a little, which he did in IRC. I'm thinking it would help remove the mountainous size of this patch, 533K, to know something about it.

1) Lines 1 to 7614 (out of 8398) is a binary diff. So, the 533K is not that big. modules/simpletest/tests/upgrade/drupal-7.bare.database.php.gz - Yes, I'm wondering too what it is. See below my plan for Long Beach Contrib meeting.

2) Lines 7615 to 8398 (700 lines of patch - plus, minus, etc lines) is for
a) Comment a change
b) Remove code
c) remove 2 files
d) 300 or so code line changes

I scrolled through it, and the quick scan said it's not that much, as 533K would make one think.

It's certainly an area I'd like to learn more of. Drupal Long Beach Contrib meeting is at the novice level, going towards intermediate. I'll have time to read the patch then. I'll report back here, what I find, with a possible approach or two. (Do not hold your breath as the meeting is in 2 weeks, and other low hanging may appear.)

I'd like to list here what the "before" and "after" test changes one must look for are. If it's just 2-3 web pages to compare, then I'll do it at the LB Contrib meeting. If it's 20-30 web pages to compare, then I'll post the URLs I think need to be examine.

No one else has taken on this and over a month has passed so assigning to self.

Looking at this, for now...I'm going to split this into two pieces. One is the actual patch, the other is the db dump. So let me get the patch portion up and running again before adding back the dump (that way, it is a lot more approachable for review as well).

Ok, this is a first stab at the issue after nearly 2 months so I need to review this as well. I've removed some of the testing stuff that was there for language testing since I need to understand what was going on in the first place (my guess is the newer db dumps had more data which collided with the data in the language dumps). Lets see where this leads.

fwiw since this is a forward port I'll make an exception for the review process and commit it as soon as it's passing tests assuming it looks OK to me - we can deal with other issues in follow-ups if we need to.

Am I correct in assuming that #1364798: Impossible to generate meaningful diffs of upgrade db dumps will make this *much* easier?

In fact, that one would make two other critical bugs/tasks much easier as well, maybe raise to major to generate some visibility?

I'm waiting on this one till tomorrow since the new 7.x release is out tomorrow (atleast the dumps will be relevant for about a month that way).

This is a rerolled patch plus all the necessary dumps. I've removed the old dumps that were there and updated drupal-7.language.database.php along with upgrade.language.test to get in line with the new tests. PLEASE PLEASE PLEASE review the minus_dump patch to understand the changes.

Also: unassigned.

I talked about this with @sun on irc and he asked me to rtbc it based on your comment in #33.

With that said, he also mentioned (and I wholly agree) that #1364798: Impossible to generate meaningful diffs of upgrade db dumps is not ready so we should not expect minor upgrade path testing anytime soon (which that issue will hopefully aim to resolve). As such, there shouldn't be anything blocking this issue.

http://drupal.org/node/1207020#avoid-commit-conflicts

Pretty much a perfect example.

Thanks! Committed/pushed this one to 8.x

Removing tag