Write documentation in the addthis.api.php for the method hook_addthis_display_markup_alter.

See getDisplayMarkup in classes/AddThis.php for the arguments being passed.

CommentFileSizeAuthor
#5 addthis_markup_alter_doc-1348498-5.patch733 bytesgnuget
#3 addthis_markup_alter_doc-1348498-3.patch759 bytesgnuget

Comments

gnuget’s picture

gnuget
Primary language Spanish
commented
Assigned: Unassigned » gnuget

I want to work on this.

But, the method is hook_addthis_display_markup_alter or hook_addthis_display_markup ?

In the method getDisplayMarkup exists a module_implements for the second one but not for the first one.

matglas86’s picture

matglas86 commented
Title: Write documentation for addthis_display_markup_alter » Write documentation for the alter hook addthis_markup_alter

I made a mistake in the naming. This should be addthis_markup_alter. The alter methods don't need a module_implements to execute it.

see drupal_alter for more information on the way alter function work.

Thanks for picking this up.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new addthis_markup_alter_doc-1348498-3.patch759 bytes

Done.

I attached the patch

matglas86’s picture

matglas86 commented
Status: Needs review » Needs work

Change the function name to hook_addthis_markup_alter and add the text "Implements hook_addthis_markup_alter." as the first line of the description.

Change the inline comment too.

+  // Let's add a custom CSS class for given a particular design to our
+  // twitter button, so we can change the look.
gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new addthis_markup_alter_doc-1348498-5.patch733 bytes

Thanks for the feedback.

patch attached

matglas86’s picture

matglas86 commented
Status: Needs review » Reviewed & tested by the community

Great. I'll pick it up and commit it later.

matglas86’s picture

matglas86 commented
Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.