Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
base system
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Nov 2011 at 01:30 UTC
Updated:
4 Jan 2014 at 01:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedComment #2
Anonymous (not verified) commentedComment #3
tregeagle commentedPatched fine, looks good.
Comment #4
xjmThanks for the cleanup! One standards fix and one question:
This should be one line, 80 chars or less. I'd suggest making the description a little more generic and moving the list of function names to a second paragraph if desired.
While we're changing this, do we want to add parens for valid_url()?
Comment #5
LSU_JBob commentedre-rolled, it seems that the function names have been taken care of.
picked up from the novice queue.
Comment #6
xjmI just went through and confirmed all the other fixes were covered by #899444: Declutter "System" test group by applying coding standards fixes to common.test. Thanks @LSU_JBob!
Comment #7
dries commentedCommitted to 8.x. Thanks.
Comment #8
xjmI think we can probably backport this cleanup too.
Comment #9
albert volkman commentedD7 backport.
Comment #10
xjmYep.
Comment #11
webchickCommitted and pushed to 7.x. Thanks!