Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are a few erroneous comments in common.test and two functions that are named "UnitTest" that are not unit tests. The attached patch fixes them.
Comment | File | Size | Author |
---|---|---|---|
#9 | comment_cleanup_common_tests-1347836-d7-9.patch | 770 bytes | Albert Volkman |
#5 | comment_cleanup_common_tests-1347836-5480960.patch | 806 bytes | LSU_JBob |
common-test-comments.patch | 2 KB | linclark | |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #3
tregeagle CreditAttribution: tregeagle commentedPatched fine, looks good.
Comment #4
xjmThanks for the cleanup! One standards fix and one question:
This should be one line, 80 chars or less. I'd suggest making the description a little more generic and moving the list of function names to a second paragraph if desired.
While we're changing this, do we want to add parens for valid_url()?
Comment #5
LSU_JBob CreditAttribution: LSU_JBob commentedre-rolled, it seems that the function names have been taken care of.
picked up from the novice queue.
Comment #6
xjmI just went through and confirmed all the other fixes were covered by #899444: Declutter "System" test group by applying coding standards fixes to common.test. Thanks @LSU_JBob!
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #8
xjmI think we can probably backport this cleanup too.
Comment #9
Albert Volkman CreditAttribution: Albert Volkman commentedD7 backport.
Comment #10
xjmYep.
Comment #11
webchickCommitted and pushed to 7.x. Thanks!