Create 'lib' directory in git to avoid "mkdir(): Permission denied filesystem.inc:249" error

Adding just lib directory wouldn't make much change, you'd be unable to write to it anyway.

Better solution is to inform user about the permissions problem, not to leave her in terminal with this generic error. Patch attached.

This is an improvement, but it would be even better to preflight the command with a call to is_writable, so that the error message only refers to permissions when that is in fact the source of the error.

It can not be any other issue, but permissions - hence that message. If you still insist, maybe to change error message to 'Unable to create directory !dir', without the permissions notice?

mkdir can also fail if one of the parent folders is missing. #2 is best, and not much harder than #3.

Yes, but this function recursively creates parent directories if needed. It acts like 'mkdir -p'. Only reason it might fail is that it does not have write permissions.

Is mkdir guaranteed by specification to only fail per #5? Out of disk space / inodes may be rare, but that does not change the fact that #1 is wrong, #3 is nominally okay, and #2 is best.

Ok, in unlikely event we run out of inodes, user will be informed that something other than permissions has happened.

Also, I expanded drush_mkdir(), since one-liner was very unreadable.

Re-roll with coding standard fix and squashing multiple commits into one.

As my upgrade stopped on line 249 of filesystem.inc (and with a memory_limit error) I tried this patch. There is no memory limit error anymore but still the upgrade does not continue. After I answer the firs question below with 'y' I get:

Would you like to continue anyway? (y/n): y
The directory  does not exist.
Would you like to create it? (y/n): y

D:\xampp\htdocs>

The second question is answered by the upgrade process, not by me.

Now I am really stuck. Do not know what to try else.

Thanks for helping me out!

Edit: Now could it be the directory can not be created because the whole path contains spaces? That was my problem with navigating with cygwin to apply the patch.
If anyone could tell me what directory to make I will make it by hand and then will try again.
Edit2: well, I think I see there is a function in filesystem.inc which should handle the space problem. Sorry.

Well....
I changed the root directory int "aliases.drushrc.php" to "D:\xampp\htdocs\waspik" and now the upgrade continued.
So recap: it was all a wrong root directory.

But ...
the upgrade was still not succesfull. I will start a new support request for new questions,

Committed. Thanks.

This is related to #1069364: Bypass default PEAR Console_Table.

Agree with #12.

Added lib and lib/README.txt to git, and fixed up .gitignore. Maybe my change to .gitignore was spurrious, as I needed to use -f to add the README anyway.

Re-open if there are any issues with this; if it's okay, the same thing could be done to the drush-4.x branch.

I just installed drush to a new server using the pear channel. I get this error. How do I modify the permissions to make this work?

ice5nake, this is fixed in the latest HEAD.

Just start drush once as root, and you'll be good afterwards.

Backported the error reporting fix, but we dont use lib in drush4 so i left that one.