As a result of implementing theme integration (#877266: Parse theme info for font declarations), we should give the user information on how he could add the fonts to his theme.
Would this work? See screenshot.

A bit of information on top of this page using a hook_help() function might be needed.

CommentFileSizeAuthor
Font theme.info suggestions78.67 KBBarisW

Comments

BarisW’s picture

BarisW commented
Issue summary: View changes

Updated issue summary.

BarisW’s picture

BarisW commented
Issue summary: View changes

Updated issue summary.

BarisW’s picture

BarisW commented
Issue summary: View changes

Updated issue summary.

sreynen’s picture

sreynen commented

I think it would be better to show the whole thing in a single textarea, so someone can just copy and paste it all. Most people will never use this, so it's probably better to hide it away on a separate page. What if we added a third tab to the apply page for this, so "By Font", "By CSS Selector" and "In Theme"?

sreynen’s picture

sreynen commented
Status: Active » Needs review

I just committed one possible way to do this. Thoughts?

Once this is done, I'd like to do a final 2.0 release.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Changed one line in the code:

<?php
$fonts = fontyourface_get_fonts();
?>

to 

<?php
$fonts = fontyourface_get_fonts('enabled = 1');
?>

Because fontyourface_get_fonts() loads fonts that are enabled AND have a CSS selector.

Committed it.

sreynen’s picture

sreynen commented
Status: Reviewed & tested by the community » Fixed

I think we can call this fixed then.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Issue link was missing